All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Jork Loeser <Jork.Loeser@microsoft.com>,
	KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Juergen Gross <jgross@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH] x86: enable RCU based table free when PARAVIRT
Date: Thu, 24 Aug 2017 11:47:46 +0300	[thread overview]
Message-ID: <20170824084746.brbfcth76yew6lr2@node.shutemov.name> (raw)
In-Reply-To: <CA+55aFy5M-0Ru-SMoyymewffawyMs8cS2TzjodyjbAtXBp24xw@mail.gmail.com>

On Wed, Aug 23, 2017 at 04:03:53PM -0700, Linus Torvalds wrote:
> On Wed, Aug 23, 2017 at 3:36 PM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> >
> > Below is test cases that allocates a lot of page tables and measuare
> > fork/exit time. (I'm not entirely sure it's the best way to stress the
> > codepath.)
> 
> Looks ok to me. Doing a profile (without the RCU freeing, obviously) gives me
> 
>    0.77%  a.out    [kernel.vmlinux]  [k] free_pgd_range
> 
> 
>                                           ▒
> 
> so it does seem to spend time in the page directory code.
> 
> > Unpatched:      average 4.8322s, stddev 0.114s
> > Patched:        average 4.8362s, stddev 0.111s
> 
> Ok, I vote for avoiding the complexity of two different behaviors, and
> just making the page table freeing use RCU unconditionally.
> 
> If actively trying to trigger that code doesn't show a real measurable
> difference, I don't think it matters, and the fewer different code
> paths we have, the better.

Numbers from bigger 2-socket machine:

Unpatched:	average 5.0542s, stddev 0.058s
Patched:	average 5.0440s, stddev 0.072s

Still fine.

I don't see a reason not to go this path.

-- 
 Kirill A. Shutemov

  parent reply	other threads:[~2017-08-24  8:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 13:45 [PATCH] x86: enable RCU based table free when PARAVIRT Vitaly Kuznetsov
2017-08-23 18:26 ` Linus Torvalds
2017-08-23 18:26 ` Linus Torvalds
2017-08-23 19:59   ` Kirill A. Shutemov
2017-08-23 20:27     ` Linus Torvalds
2017-08-23 20:27     ` Linus Torvalds
2017-08-23 22:36       ` Kirill A. Shutemov
2017-08-23 22:36       ` Kirill A. Shutemov
2017-08-23 23:03         ` Linus Torvalds
2017-08-23 23:03         ` Linus Torvalds
2017-08-24  8:47           ` Vitaly Kuznetsov
2017-08-24  8:47           ` Vitaly Kuznetsov
2017-08-24  8:47           ` Kirill A. Shutemov
2017-08-24  8:47           ` Kirill A. Shutemov [this message]
2017-08-23 19:59   ` Kirill A. Shutemov
2017-08-23 13:45 Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824084746.brbfcth76yew6lr2@node.shutemov.name \
    --to=kirill@shutemov.name \
    --cc=Jork.Loeser@microsoft.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vkuznets@redhat.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.