From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 09/19] sd, sr: Convert two assignments into warning statements
Date: Thu, 24 Aug 2017 11:08:11 +0200 [thread overview]
Message-ID: <20170824090811.GI19886@lst.de> (raw)
In-Reply-To: <20170823214009.15015-10-bart.vanassche@wdc.com>
On Wed, Aug 23, 2017 at 02:39:59PM -0700, Bart Van Assche wrote:
> Before scsi_prep_fn() calls the ULP .init_command() callback
> function it stores the SCSI command pointer in request.special.
> This means that the SCpnt = rq->special assignments in the sd
> and sr drivers assign a pointer to itself. Hence convert these
> two assignment statements into warning statements.
Looks good.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, in the longer run we should aim to kill the special pointer
in struct request entirely.
next prev parent reply other threads:[~2017-08-24 9:08 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 21:39 [PATCH 00/19] SCSI patches for kernel v4.14 Bart Van Assche
2017-08-23 21:39 ` [PATCH 01/19] Remove an obsolete function declaration Bart Van Assche
2017-08-24 9:02 ` Christoph Hellwig
2017-08-23 21:39 ` [PATCH 02/19] Avoid sign extension of scsi_device.type Bart Van Assche
2017-08-24 6:10 ` Hannes Reinecke
2017-08-24 9:02 ` Christoph Hellwig
2017-08-23 21:39 ` [PATCH 03/19] Suppress gcc 7 fall-through warnings reported with W=1 Bart Van Assche
2017-08-24 9:03 ` Christoph Hellwig
2017-08-23 21:39 ` [PATCH 04/19] Convert a strncmp() call into a strcmp() call Bart Van Assche
2017-08-24 9:03 ` Christoph Hellwig
2017-08-25 15:43 ` Hannes Reinecke
2017-08-23 21:39 ` [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it Bart Van Assche
2017-08-24 9:05 ` Christoph Hellwig
2017-08-24 16:17 ` Bart Van Assche
2017-08-23 21:39 ` [PATCH 06/19] Document which queue type a function is intended for Bart Van Assche
2017-08-24 9:05 ` Christoph Hellwig
2017-08-24 16:57 ` Bart Van Assche
2017-08-24 16:58 ` hch
2017-08-24 17:22 ` Bart Van Assche
2017-08-25 15:44 ` Hannes Reinecke
2017-08-23 21:39 ` [PATCH 07/19] Fix RCU handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-24 9:07 ` Christoph Hellwig
2017-08-24 16:54 ` Bart Van Assche
2017-08-25 5:58 ` Seymour, Shane M
2017-08-25 6:59 ` hch
2017-08-25 20:04 ` Bart Van Assche
2017-08-28 2:02 ` Seymour, Shane M
2017-08-25 15:49 ` Hannes Reinecke
2017-08-25 16:26 ` Bart Van Assche
2017-08-23 21:39 ` [PATCH 08/19] Use blk_mq_rq_to_pdu() to convert a request to a SCSI command pointer Bart Van Assche
2017-08-24 9:07 ` Christoph Hellwig
2017-08-23 21:39 ` [PATCH 09/19] sd, sr: Convert two assignments into warning statements Bart Van Assche
2017-08-24 9:08 ` Christoph Hellwig [this message]
2017-08-23 21:40 ` [PATCH 10/19] sd: Fix indentation Bart Van Assche
2017-08-24 9:08 ` Christoph Hellwig
2017-08-25 15:50 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 11/19] sd: Remove a useless comparison Bart Van Assche
2017-08-25 15:50 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 12/19] sg: Fix type of last blk_trace_setup() argument Bart Van Assche
2017-08-24 9:08 ` Christoph Hellwig
2017-08-25 15:51 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 13/19] libiscsi: Fix indentation Bart Van Assche
2017-08-24 9:08 ` Christoph Hellwig
2017-08-25 15:51 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 14/19] libsas: Remove a set-but-not-used variable Bart Van Assche
2017-08-24 9:09 ` Christoph Hellwig
2017-08-25 15:51 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 15/19] libsas: Annotate fall-through in a switch statement Bart Van Assche
2017-08-24 9:09 ` Christoph Hellwig
2017-08-25 15:52 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 16/19] scsi_transport_sas, sas_tlr_supported(): Check kzalloc() return value Bart Van Assche
2017-08-24 9:09 ` Christoph Hellwig
2017-08-25 15:52 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning Bart Van Assche
2017-08-24 9:11 ` Christoph Hellwig
2017-08-24 16:27 ` Bart Van Assche
2017-08-25 15:29 ` hch
2017-08-25 15:40 ` Bart Van Assche
2017-08-25 15:56 ` hch
2017-08-23 21:40 ` [PATCH 18/19] scsi_debug: Remove a set-but-not-used variable Bart Van Assche
2017-08-24 9:12 ` Christoph Hellwig
2017-08-25 15:53 ` Hannes Reinecke
2017-08-23 21:40 ` [PATCH 19/19] iscsi_tcp: " Bart Van Assche
2017-08-24 9:12 ` Christoph Hellwig
2017-08-25 15:53 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824090811.GI19886@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@sandisk.com \
--cc=bart.vanassche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.