From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/6] raid5: remove a call to get_start_sect Date: Thu, 24 Aug 2017 11:18:23 +0200 Message-ID: <20170824091823.GC20189@lst.de> References: <20170823171032.30529-1-hch@lst.de> <20170823171032.30529-3-hch@lst.de> <20170823182338.einsyonnfucyn73y@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170823182338.einsyonnfucyn73y@kernel.org> Sender: linux-raid-owner@vger.kernel.org To: Shaohua Li Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org List-Id: linux-raid.ids On Wed, Aug 23, 2017 at 11:23:38AM -0700, Shaohua Li wrote: > On Wed, Aug 23, 2017 at 07:10:28PM +0200, Christoph Hellwig wrote: > > The block layer always remaps partitions before calling into the > > ->make_request methods of drivers. Thus the call to get_start_sect in > > in_chunk_boundary will always return 0 and can be removed. > > > > Signed-off-by: Christoph Hellwig > > --- > > drivers/md/raid5.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > > index 0fc2748aaf95..d687aeb1b538 100644 > > --- a/drivers/md/raid5.c > > +++ b/drivers/md/raid5.c > > @@ -5092,10 +5092,12 @@ static int raid5_congested(struct mddev *mddev, int bits) > > static int in_chunk_boundary(struct mddev *mddev, struct bio *bio) > > { > > struct r5conf *conf = mddev->private; > > - sector_t sector = bio->bi_iter.bi_sector + get_start_sect(bio->bi_bdev); > > + sector_t sector = bio->bi_iter.bi_sector; > > unsigned int chunk_sectors; > > unsigned int bio_sectors = bio_sectors(bio); > > > > + WARN_ON_ONCE(bio->bi_partno); > > + Meh, of course bi_partno is only added a few patches later, so this breaks bisectability. But given that the patch is already in there's probably nothing I can do here.