From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [RFC] net/mlx5: support count flow action
Date: Thu, 24 Aug 2017 17:08:57 +0200
Message-ID: <20170824150857.GP4544@autoinstall.dev.6wind.com>
References: <1503318941-42015-1-git-send-email-orika@mellanox.com>
 <20170824065419.GH12995@autoinstall.dev.6wind.com>
 <AM4PR05MB3202536A61936AC4B8503EFCDB9A0@AM4PR05MB3202.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: "adrien.mazaruil@6wind.com" <adrien.mazaruil@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ori Kam <orika@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id 679947D13
 for <dev@dpdk.org>; Thu, 24 Aug 2017 17:09:07 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id x128so6993216wmg.1
 for <dev@dpdk.org>; Thu, 24 Aug 2017 08:09:07 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <AM4PR05MB3202536A61936AC4B8503EFCDB9A0@AM4PR05MB3202.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ori,

On Thu, Aug 24, 2017 at 02:04:32PM +0000, Ori Kam wrote:
> Hi Nelio,
> 
> Please see my comments in line.
> 
> Ori
> 
> > -----Original Message-----
> > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com]
> > Sent: Thursday, August 24, 2017 9:54 AM
> > To: Ori Kam <orika@mellanox.com>
> > Cc: adrien.mazaruil@6wind.com; dev@dpdk.org
> > Subject: Re: [RFC] net/mlx5: support count flow action
> > 
> > Hi Ori,
> > 
> > Please keep the coding style of the file, and pass checkpatch before
> > submitting a patch on the mailing list.  It helps the review by having a correct
> > patch respecting the coding style of the file.
> > I won't spot out here all the coding style issues, if you need some help, feel
> > free to ask.
> > 
> Sorry won't happen again.

No problem, first contribution is always complicate.

> > On Mon, Aug 21, 2017 at 03:35:41PM +0300, Ori Kam wrote:
> > > Support count flow action.
> > 
> > Why copy/pasting the title in the commit message?
> > 
> I was under the impression that main function of the RFC should also be in the message body.

No, it is not necessary, the commit message should bring useful information by
still being short and precise.

>[...]
> > > ---
> > >  drivers/net/mlx5/mlx5.h      |   4 ++
> > >  drivers/net/mlx5/mlx5_flow.c | 163
> > > ++++++++++++++++++++++++++++++++++++++++++-
> > 
> > There are missing changes in the Makefile to have the
> > HAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT and the include of the
> > mlx5_autoconf.h in mlx5_flow.c.
> > 
> I haven't added them since this feature is not supported yet, and 
> I don't want anybody trying to activate them.
> When the feature will be supported on the verbs then I will update
> those files. 

Ok, so a new version should be sent soon :)

>[...]
> > 
> Will be update according to your suggestion.
 
Thanks,

-- 
Nélio Laranjeiro
6WIND