From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754183AbdHXX7S (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 19:59:18 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:41932 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753203AbdHXX7Q (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 19:59:16 -0400
Date: Thu, 24 Aug 2017 16:59:05 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Arnd Bergmann <arnd@arndb.de>, devel@driverdev.osuosl.org,
        Yan-Hsuan Chuang <yhchuang@realtek.com>, linux-kernel@vger.kernel.org,
        Birming Chiu <birming@realtek.com>,
        Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency
Message-ID: <20170824235905.GA23042@kroah.com>
References: <20170823132337.517466-1-arnd@arndb.de>
 <20170823132337.517466-2-arnd@arndb.de>
 <b1d99a9d-8f88-5599-8334-6441549ed0a7@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b1d99a9d-8f88-5599-8334-6441549ed0a7@lwfinger.net>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 24, 2017 at 02:23:08PM -0500, Larry Finger wrote:
> On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> > Like the version in drivers/net/wireless, this driver requires the
> > MAC80211 framework, otherwise we run into a link error:
> > 
> > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > 
> > This adds the Kconfig dependency for it.
> > 
> > Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Greg,
> 
> I lost track of which version of this patch you are taking. The one that
> Randy Dunlap sent that added NETDEVICES was better than the initial version,
> but this one with MAC80211 is the correct one. Randy's patch is in the
> latest pull I did on staging.
> 
> Do you want an updated patch?

Nope, all should be good now, I've fixed it by hand.  Look in my tree
and if it's still wrong there, please send me a fixup.

thanks,

greg k-h