All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marta Lofstedt <marta.lofstedt@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s
Date: Fri, 25 Aug 2017 13:40:29 +0300	[thread overview]
Message-ID: <20170825104029.18440-1-marta.lofstedt@intel.com> (raw)
In-Reply-To: <20170628111652.8019-1-marta.lofstedt@intel.com>

From: "Lofstedt, Marta" <marta.lofstedt@intel.com>

The subtests: igt@kms_frontbuffer_tracking@fbc-*draw*
has non-consistent results, pending between fail and pass.
The fails are always due to "FBC disabled".
With this increase in timeout the flip-flop behavior is no
longer reproducible.

This is a partial revert of:
64590c7b768dc8d8dd962f812d5ff5a39e7e8b54,
where the timeout was decreased from 5s to 2s.
After investigating the timeout needed, the conclusion is that
the longer timeout is only needed when the test swaps between
some specific draw domains, typically blt vs. mmap_cpu.
The objective of the FBC part of the tests is not to benchmark
draw domain changes, it is to check that FBC was (re-)enabled.

V2: Added documentation

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101623
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
Acked-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index e03524f1..2538450c 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -924,7 +924,7 @@ static bool fbc_stride_not_supported(void)
 
 static bool fbc_wait_until_enabled(void)
 {
-	return igt_wait(fbc_is_enabled(), 2000, 1);
+	return igt_wait(fbc_is_enabled(), 5000, 1);
 }
 
 static bool psr_wait_until_enabled(void)
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-25 10:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 11:16 [PATCH i-g-t] tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s Marta Lofstedt
2017-08-04  9:47 ` Lofstedt, Marta
2017-08-04 18:56   ` Paulo Zanoni
2017-08-07  6:51     ` Lofstedt, Marta
2017-08-07 14:54       ` Paulo Zanoni
2017-08-08 11:14         ` Lofstedt, Marta
2017-08-11 10:16           ` Lofstedt, Marta
2017-08-25 10:40 ` Marta Lofstedt [this message]
2017-08-25 10:46   ` [PATCH i-g-t v2] " Petri Latvala
2017-08-25 10:47   ` Chris Wilson
2017-08-25 11:54     ` Lofstedt, Marta
2017-08-25 12:50     ` Lofstedt, Marta
2017-08-25 13:11       ` Chris Wilson
2017-08-25 13:33         ` Lofstedt, Marta
2017-08-29  7:16           ` Lofstedt, Marta
2017-09-01 19:12         ` Paulo Zanoni
2017-09-04 10:45           ` Chris Wilson
2017-09-04 18:26             ` Paulo Zanoni
2017-08-25 12:24 ` ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: increase FBC wait timeout to 5s (rev2) Patchwork
2017-08-25 17:40 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825104029.18440-1-marta.lofstedt@intel.com \
    --to=marta.lofstedt@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.