From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933493AbdHYPF3 (ORCPT ); Fri, 25 Aug 2017 11:05:29 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:41850 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933503AbdHYPD1 (ORCPT ); Fri, 25 Aug 2017 11:03:27 -0400 Date: Fri, 25 Aug 2017 08:03:24 -0700 From: Christoph Hellwig To: Hans de Goede Cc: Christoph Hellwig , Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration Message-ID: <20170825150324.GA23830@infradead.org> References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-2-hdegoede@redhat.com> <20170825145806.GA6706@infradead.org> <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 25, 2017 at 05:00:31PM +0200, Hans de Goede wrote: > I've already removed all the typedefs and camel-case outside of > include/uapi/linux > > The ones in include/uapi/linux are preserved to preserve API > compatibility with the existing VirtualBox userspace tools. When merging new drivers we need to fix up the user abis anyway, we don't want to be stuck with mistakes from the past. And the APIs look pretty bad, so there will be a lot work required after this basic cleanup anyway.