From: Aleksander Morgado <aleksander@aleksander.es>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] autoconf: use host-gettext's autopoint if available in autoreconf
Date: Sun, 27 Aug 2017 13:09:20 +0200 [thread overview]
Message-ID: <20170827110920.15579-1-aleksander@aleksander.es> (raw)
Commit 7ee8ebbd813ad0a6d2392ef628c17241 explicitly disabled autopoint
calls during autoreconf, to avoid having the host autopoint called, as
there was no host-gettext package.
Commit 3a188b578e490f2a8b5922329b7abfae introduced the host-gettext
package support.
This commit recovers the support for automatically calling autopoint
during autoreconf.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
Hey,
I see this is a recurring issue when a package that builds from git (bootstrapping using autoreconf before configure) requires gettext processing. automake would fail as autopoint wasn't being run (disabled in buildroot's autoconf package) and therefore not creating config.rpath and ABOUT-NLS (among other things, although these are the ones automake complains about). Specifying $(PKG)_GETTEXTIZE isn't an option as that may actually update the gnulib-imported files in a non-expected way, and "touch"-ing the missing files just seems a bit of a hack...
Calling autopoint from autoreconf was disabled back in 2011 because no host-gettext package was available, but this package was added in 2013, so how about removing that limitation?
Cheers!
---
package/autoconf/autoconf.mk | 2 +-
package/gettext/gettext.mk | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/autoconf/autoconf.mk b/package/autoconf/autoconf.mk
index e5f474c72..f1c60224f 100644
--- a/package/autoconf/autoconf.mk
+++ b/package/autoconf/autoconf.mk
@@ -23,4 +23,4 @@ $(eval $(host-autotools-package))
# variables used by other packages
AUTOCONF = $(HOST_DIR)/bin/autoconf
AUTOHEADER = $(HOST_DIR)/bin/autoheader
-AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL="$(ACLOCAL)" AUTOCONF="$(AUTOCONF)" AUTOHEADER="$(AUTOHEADER)" AUTOMAKE="$(AUTOMAKE)" AUTOPOINT=/bin/true $(HOST_DIR)/bin/autoreconf -f -i -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)"
+AUTORECONF = $(HOST_CONFIGURE_OPTS) ACLOCAL="$(ACLOCAL)" AUTOCONF="$(AUTOCONF)" AUTOHEADER="$(AUTOHEADER)" AUTOMAKE="$(AUTOMAKE)" AUTOPOINT="$(AUTOPOINT)" $(HOST_DIR)/bin/autoreconf -f -i -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)" --verbose
diff --git a/package/gettext/gettext.mk b/package/gettext/gettext.mk
index ec9588f8a..08afc8fc3 100644
--- a/package/gettext/gettext.mk
+++ b/package/gettext/gettext.mk
@@ -95,6 +95,7 @@ endef
HOST_GETTEXT_POST_INSTALL_HOOKS += HOST_GETTEXT_ADD_ABOUT_NLS
GETTEXTIZE = $(HOST_CONFIGURE_OPTS) AUTOM4TE=$(HOST_DIR)/bin/autom4te $(HOST_DIR)/bin/gettextize -f
+AUTOPOINT = $(HOST_DIR)/bin/autopoint
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.14.1
next reply other threads:[~2017-08-27 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 11:09 Aleksander Morgado [this message]
2017-10-23 8:53 ` [Buildroot] [PATCH] autoconf: use host-gettext's autopoint if available in autoreconf Arnout Vandecappelle
2017-11-02 17:27 ` Aleksander Morgado
2017-11-04 21:00 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827110920.15579-1-aleksander@aleksander.es \
--to=aleksander@aleksander.es \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.