From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdH1GTe (ORCPT ); Mon, 28 Aug 2017 02:19:34 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51733 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750797AbdH1GTc (ORCPT ); Mon, 28 Aug 2017 02:19:32 -0400 Date: Mon, 28 Aug 2017 09:19:06 +0300 From: Dan Carpenter To: Himanshu Jha Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, insafonov@gmail.com, linux-kernel@vger.kernel.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net Subject: Re: [PATCH] staging: rtl8723bs: remove memset before memcpy Message-ID: <20170828061231.yalsogu62qskhter@mwanda> References: <1503864811-8226-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503864811-8226-1-git-send-email-himanshujha199640@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Build successfully. > Thanks for the patch, it looks good. You don't need to say that it builds successfully, because we already assume that's true. > Signed-off-by: Himanshu Jha > --- Sometimes I put a comment here under the cut off line if I want people to know that I haven't tested a patch. Anyway, don't resend the patch. It's fine as-is (unless Greg complains) but it's just for future reference. regards, dan carpenter