All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Hannes Reinecke <hare@suse.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Shane Seymour <shane.seymour@hpe.com>
Subject: Re: [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03]
Date: Mon, 28 Aug 2017 10:07:53 +0200	[thread overview]
Message-ID: <20170828080753.GB2851@lst.de> (raw)
In-Reply-To: <20170825203601.23612-3-bart.vanassche@wdc.com>

This looks generally good.  But I wonder if there is a way to
factor the assining/clearing sequence into little helpers instead
of duplicating it?

      parent reply	other threads:[~2017-08-28  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 20:35 [PATCH 0/2] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-25 20:36 ` [PATCH 1/2] Introduce scsi_get_vpd_buf() Bart Van Assche
2017-08-28  6:02   ` Seymour, Shane M
2017-08-28  8:05   ` Christoph Hellwig
2017-08-25 20:36 ` [PATCH 2/2] Rework handling of scsi_device.vpd_pg8[03] Bart Van Assche
2017-08-28  6:24   ` Seymour, Shane M
2017-08-28  8:07   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828080753.GB2851@lst.de \
    --to=hch@lst.de \
    --cc=bart.vanassche@wdc.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=shane.seymour@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.