From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbdH1JTg (ORCPT ); Mon, 28 Aug 2017 05:19:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbdH1JTd (ORCPT ); Mon, 28 Aug 2017 05:19:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2084C5D68D Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 28 Aug 2017 11:19:31 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v2 17/19] perf, tools, stat: Support duration_time for metrics Message-ID: <20170828091931.GD4948@krava> References: <20170811232634.30465-1-andi@firstfloor.org> <20170811232634.30465-17-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170811232634.30465-17-andi@firstfloor.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 28 Aug 2017 09:19:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2017 at 04:26:32PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Some of the metrics formulas (like GFLOPs) need to know how long > the measurement period is. Support an internal event called duration_time, which > reports time in second. It maps to the dummy event, but is > special cased for statistics to report the walltime duration. > > So far it is not printed, but only used internally for metrics. > > Signed-off-by: Andi Kleen > --- > tools/perf/util/parse-events.l | 1 + > tools/perf/util/stat-shadow.c | 17 +++++++++++++---- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index fdb5bb52f01f..ea2426daf7e8 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -288,6 +288,7 @@ cpu-migrations|migrations { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COU > alignment-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_ALIGNMENT_FAULTS); } > emulation-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_EMULATION_FAULTS); } > dummy { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); } > +duration_time { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); } could you please use '-' (current style) instead of '_' thanks, jirka