From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751259AbdH1J4V (ORCPT ); Mon, 28 Aug 2017 05:56:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:46353 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751143AbdH1J4T (ORCPT ); Mon, 28 Aug 2017 05:56:19 -0400 Date: Mon, 28 Aug 2017 11:56:16 +0200 From: Michal Hocko To: Joonsoo Kim Cc: Vlastimil Babka , Andrew Morton , Mel Gorman , Johannes Weiner , "Aneesh Kumar K . V" , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request Message-ID: <20170828095616.GG17097@dhcp22.suse.cz> References: <1503553546-27450-1-git-send-email-iamjoonsoo.kim@lge.com> <20170825002031.GD29701@js1304-P5Q-DELUXE> <20170825073841.GD25498@dhcp22.suse.cz> <20170828001551.GA9167@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828001551.GA9167@js1304-P5Q-DELUXE> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 28-08-17 09:15:52, Joonsoo Kim wrote: > On Fri, Aug 25, 2017 at 09:38:42AM +0200, Michal Hocko wrote: > > On Fri 25-08-17 09:20:31, Joonsoo Kim wrote: > > > On Thu, Aug 24, 2017 at 11:41:58AM +0200, Vlastimil Babka wrote: > > > > On 08/24/2017 07:45 AM, js1304@gmail.com wrote: > > > > > From: Joonsoo Kim > > > > > > > > > > Freepage on ZONE_HIGHMEM doesn't work for kernel memory so it's not that > > > > > important to reserve. When ZONE_MOVABLE is used, this problem would > > > > > theorectically cause to decrease usable memory for GFP_HIGHUSER_MOVABLE > > > > > allocation request which is mainly used for page cache and anon page > > > > > allocation. So, fix it. > > > > > > > > > > And, defining sysctl_lowmem_reserve_ratio array by MAX_NR_ZONES - 1 size > > > > > makes code complex. For example, if there is highmem system, following > > > > > reserve ratio is activated for *NORMAL ZONE* which would be easyily > > > > > misleading people. > > > > > > > > > > #ifdef CONFIG_HIGHMEM > > > > > 32 > > > > > #endif > > > > > > > > > > This patch also fix this situation by defining sysctl_lowmem_reserve_ratio > > > > > array by MAX_NR_ZONES and place "#ifdef" to right place. > > > > > > > > > > Reviewed-by: Aneesh Kumar K.V > > > > > Acked-by: Vlastimil Babka > > > > > > > > Looks like I did that almost year ago, so definitely had to refresh my > > > > memory now :) > > > > > > > > Anyway now I looked more thoroughly and noticed that this change leaks > > > > into the reported sysctl. On a 64bit system with ZONE_MOVABLE: > > > > > > > > before the patch: > > > > vm.lowmem_reserve_ratio = 256 256 32 > > > > > > > > after the patch: > > > > vm.lowmem_reserve_ratio = 256 256 32 2147483647 > > > > > > > > So if we indeed remove HIGHMEM from protection (c.f. Michal's mail), we > > > > should do that differently than with the INT_MAX trick, IMHO. > > > > > > Hmm, this is already pointed by Minchan and I have answered that. > > > > > > lkml.kernel.org/r/<20170421013243.GA13966@js1304-desktop> > > > > > > If you have a better idea, please let me know. > > > > Why don't we just use 0. In fact we are reserving 0 pages... Using > > INT_MAX is just wrong. > > The number of reserved pages is calculated by "managed_pages / > ratio". Using INT_MAX, net result would be 0. Why cannot we simply special case 0? > There is a logic converting ratio 0 to ratio 1. > > if (sysctl_lowmem_reserve_ratio[idx] < 1) > sysctl_lowmem_reserve_ratio[idx] = 1 This code just tries to prevent from division by 0 but I am wondering we should simply set lowmem_reserve to 0 in that case. > If I use 0 to represent 0 reserved page, there would be a user > who is affected by this change. So, I don't use 0 for this patch. I am sorry but I do not understand? Could you be more specific please? -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 24F446B025F for ; Mon, 28 Aug 2017 05:56:20 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id v2so20510wmd.11 for ; Mon, 28 Aug 2017 02:56:20 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id y94si10303692wrc.530.2017.08.28.02.56.18 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 28 Aug 2017 02:56:18 -0700 (PDT) Date: Mon, 28 Aug 2017 11:56:16 +0200 From: Michal Hocko Subject: Re: [PATCH] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request Message-ID: <20170828095616.GG17097@dhcp22.suse.cz> References: <1503553546-27450-1-git-send-email-iamjoonsoo.kim@lge.com> <20170825002031.GD29701@js1304-P5Q-DELUXE> <20170825073841.GD25498@dhcp22.suse.cz> <20170828001551.GA9167@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828001551.GA9167@js1304-P5Q-DELUXE> Sender: owner-linux-mm@kvack.org List-ID: To: Joonsoo Kim Cc: Vlastimil Babka , Andrew Morton , Mel Gorman , Johannes Weiner , "Aneesh Kumar K . V" , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon 28-08-17 09:15:52, Joonsoo Kim wrote: > On Fri, Aug 25, 2017 at 09:38:42AM +0200, Michal Hocko wrote: > > On Fri 25-08-17 09:20:31, Joonsoo Kim wrote: > > > On Thu, Aug 24, 2017 at 11:41:58AM +0200, Vlastimil Babka wrote: > > > > On 08/24/2017 07:45 AM, js1304@gmail.com wrote: > > > > > From: Joonsoo Kim > > > > > > > > > > Freepage on ZONE_HIGHMEM doesn't work for kernel memory so it's not that > > > > > important to reserve. When ZONE_MOVABLE is used, this problem would > > > > > theorectically cause to decrease usable memory for GFP_HIGHUSER_MOVABLE > > > > > allocation request which is mainly used for page cache and anon page > > > > > allocation. So, fix it. > > > > > > > > > > And, defining sysctl_lowmem_reserve_ratio array by MAX_NR_ZONES - 1 size > > > > > makes code complex. For example, if there is highmem system, following > > > > > reserve ratio is activated for *NORMAL ZONE* which would be easyily > > > > > misleading people. > > > > > > > > > > #ifdef CONFIG_HIGHMEM > > > > > 32 > > > > > #endif > > > > > > > > > > This patch also fix this situation by defining sysctl_lowmem_reserve_ratio > > > > > array by MAX_NR_ZONES and place "#ifdef" to right place. > > > > > > > > > > Reviewed-by: Aneesh Kumar K.V > > > > > Acked-by: Vlastimil Babka > > > > > > > > Looks like I did that almost year ago, so definitely had to refresh my > > > > memory now :) > > > > > > > > Anyway now I looked more thoroughly and noticed that this change leaks > > > > into the reported sysctl. On a 64bit system with ZONE_MOVABLE: > > > > > > > > before the patch: > > > > vm.lowmem_reserve_ratio = 256 256 32 > > > > > > > > after the patch: > > > > vm.lowmem_reserve_ratio = 256 256 32 2147483647 > > > > > > > > So if we indeed remove HIGHMEM from protection (c.f. Michal's mail), we > > > > should do that differently than with the INT_MAX trick, IMHO. > > > > > > Hmm, this is already pointed by Minchan and I have answered that. > > > > > > lkml.kernel.org/r/<20170421013243.GA13966@js1304-desktop> > > > > > > If you have a better idea, please let me know. > > > > Why don't we just use 0. In fact we are reserving 0 pages... Using > > INT_MAX is just wrong. > > The number of reserved pages is calculated by "managed_pages / > ratio". Using INT_MAX, net result would be 0. Why cannot we simply special case 0? > There is a logic converting ratio 0 to ratio 1. > > if (sysctl_lowmem_reserve_ratio[idx] < 1) > sysctl_lowmem_reserve_ratio[idx] = 1 This code just tries to prevent from division by 0 but I am wondering we should simply set lowmem_reserve to 0 in that case. > If I use 0 to represent 0 reserved page, there would be a user > who is affected by this change. So, I don't use 0 for this patch. I am sorry but I do not understand? Could you be more specific please? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org