From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/9] xfs: remove unnecessary dirty bli format check for ordered bufs
Date: Mon, 28 Aug 2017 06:51:51 -0400 [thread overview]
Message-ID: <20170828105151.GC3098@localhost.localdomain> (raw)
In-Reply-To: <20170828092543.GB28514@infradead.org>
On Mon, Aug 28, 2017 at 02:25:43AM -0700, Christoph Hellwig wrote:
> This looks generally good, but I have a few nitpicks, too :)
>
> On Fri, Aug 25, 2017 at 11:05:50AM -0400, Brian Foster wrote:
> > - bool clean;
> > + bool dirty;
> > bool aborted;
> > + bool ordered;
>
> Can we just initialize all these variables here at the declaration
>
Sure..
> > + * The bli dirty state should match whether the blf has logged segments
> > + * except for ordered buffers, where only the bli should be dirty.
> > */
> > + dirty = (flags & XFS_BLI_DIRTY) ? true : false;
> > + ordered = (flags & XFS_BLI_ORDERED) ? true : false;
>
> No need for the "? true : false" both for these two and the existing
> aborted case.
>
Ok, so I assume you mean to change these to something like:
bool aborted = !!(bip->bli_flags & XFS_BLI_ABORTED);
...
> > +/*
> > + * Return true if the buffer has any ranges logged/dirtied by a transaction,
> > + * false otherwise.
> > + */
> > +bool
> > +xfs_buf_item_dirty_format(
>
> Do you need this outside of xfs_buf_item.c later?
>
It's used in xfs_trans_buf.c as well.
Brian
next prev parent reply other threads:[~2017-08-28 10:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 15:05 [PATCH 0/9] xfs: xfs: refactor ordered buffer logging code Brian Foster
2017-08-25 15:05 ` [PATCH 1/9] xfs: open-code xfs_buf_item_dirty() Brian Foster
2017-08-25 15:26 ` Darrick J. Wong
2017-08-28 9:20 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 2/9] xfs: remove unnecessary dirty bli format check for ordered bufs Brian Foster
2017-08-25 15:51 ` Darrick J. Wong
2017-08-28 9:25 ` Christoph Hellwig
2017-08-28 10:51 ` Brian Foster [this message]
2017-08-25 15:05 ` [PATCH 3/9] xfs: ordered buffer log items are never formatted Brian Foster
2017-08-25 15:26 ` Darrick J. Wong
2017-08-28 9:26 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 4/9] xfs: refactor buffer logging into buffer dirtying helper Brian Foster
2017-08-28 9:28 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 5/9] xfs: don't log dirty ranges for ordered buffers Brian Foster
2017-08-25 15:51 ` Darrick J. Wong
2017-08-28 9:29 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 6/9] xfs: skip bmbt block ino validation during owner change Brian Foster
2017-08-25 15:35 ` Darrick J. Wong
2017-08-25 18:11 ` Brian Foster
2017-08-28 9:44 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 7/9] xfs: move bmbt owner change to last step of extent swap Brian Foster
2017-08-25 15:57 ` Darrick J. Wong
2017-08-28 9:46 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 8/9] xfs: disallow marking previously dirty buffers as ordered Brian Foster
2017-08-25 16:50 ` Darrick J. Wong
2017-08-28 9:34 ` Christoph Hellwig
2017-08-25 15:05 ` [PATCH 9/9] xfs: relog dirty buffers during swapext bmbt owner change Brian Foster
2017-08-25 16:53 ` Darrick J. Wong
2017-08-28 9:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828105151.GC3098@localhost.localdomain \
--to=bfoster@redhat.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.