* [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround
@ 2017-08-28 11:34 Marta Lofstedt
2017-08-28 11:49 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Marta Lofstedt @ 2017-08-28 11:34 UTC (permalink / raw)
To: intel-gfx
Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was
supposed to solve below bug. However, the patch I tested
is not the same as the one that got merged.
With this addition the test pass.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101664
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
drivers/gpu/drm/i915/intel_pipe_crc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
index 4e22bb927fed..f79f9a42798d 100644
--- a/drivers/gpu/drm/i915/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
@@ -951,8 +951,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name,
else if ((IS_HASWELL(dev_priv) ||
IS_BROADWELL(dev_priv)) && crtc->index == PIPE_A)
hsw_pipe_A_crc_wa(dev_priv, false);
-
- hsw_enable_ips(intel_crtc);
}
pipe_crc->skipped = 0;
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Beef up of Beef up the IPS vs. CRC workaround
2017-08-28 11:34 [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround Marta Lofstedt
@ 2017-08-28 11:49 ` Patchwork
2017-08-28 12:18 ` [PATCH v2] " Marta Lofstedt
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-28 11:49 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround
URL : https://patchwork.freedesktop.org/series/29425/
State : failure
== Summary ==
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h
CHK include/generated/utsrelease.h
CHK include/generated/bounds.h
CHK include/generated/timeconst.h
CHK include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
CHK scripts/mod/devicetable-offsets.h
CHK include/generated/compile.h
CHK kernel/config_data.h
CC [M] drivers/gpu/drm/i915/intel_pipe_crc.o
drivers/gpu/drm/i915/intel_pipe_crc.c: In function ‘intel_crtc_set_crc_source’:
drivers/gpu/drm/i915/intel_pipe_crc.c:922:21: error: unused variable ‘intel_crtc’ [-Werror=unused-variable]
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
^~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:302: recipe for target 'drivers/gpu/drm/i915/intel_pipe_crc.o' failed
make[4]: *** [drivers/gpu/drm/i915/intel_pipe_crc.o] Error 1
scripts/Makefile.build:561: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:561: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:561: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1019: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] drm/i915: Beef up of Beef up the IPS vs. CRC workaround
2017-08-28 11:34 [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround Marta Lofstedt
2017-08-28 11:49 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-08-28 12:18 ` Marta Lofstedt
2017-08-28 14:40 ` Ville Syrjälä
2017-08-28 12:29 ` ✓ Fi.CI.BAT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2) Patchwork
2017-08-28 14:42 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Marta Lofstedt @ 2017-08-28 12:18 UTC (permalink / raw)
To: intel-gfx
Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was
supposed to solve below bug. However, the patch I tested
is not the same as the one that got merged.
With this addition the test pass.
V2: removed unused: "struct intel_crtc *intel_crtc"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101664
Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
drivers/gpu/drm/i915/intel_pipe_crc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
index 4e22bb927fed..96043a51c1bf 100644
--- a/drivers/gpu/drm/i915/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
@@ -919,7 +919,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name,
{
struct drm_i915_private *dev_priv = crtc->dev->dev_private;
struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[crtc->index];
- struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
enum intel_display_power_domain power_domain;
enum intel_pipe_crc_source source;
u32 val = 0; /* shut up gcc */
@@ -951,8 +950,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name,
else if ((IS_HASWELL(dev_priv) ||
IS_BROADWELL(dev_priv)) && crtc->index == PIPE_A)
hsw_pipe_A_crc_wa(dev_priv, false);
-
- hsw_enable_ips(intel_crtc);
}
pipe_crc->skipped = 0;
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)
2017-08-28 11:34 [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround Marta Lofstedt
2017-08-28 11:49 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-08-28 12:18 ` [PATCH v2] " Marta Lofstedt
@ 2017-08-28 12:29 ` Patchwork
2017-08-28 14:42 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-28 12:29 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)
URL : https://patchwork.freedesktop.org/series/29425/
State : success
== Summary ==
Series 29425v2 drm/i915: Beef up of Beef up the IPS vs. CRC workaround
https://patchwork.freedesktop.org/api/1.0/series/29425/revisions/2/mbox/
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215 +1
Subgroup basic-flip-after-cursor-varying-size:
pass -> FAIL (fi-hsw-4770) fdo#102402 +1
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102402 https://bugs.freedesktop.org/show_bug.cgi?id=102402
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:457s
fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:443s
fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:357s
fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:559s
fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:255s
fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:520s
fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:518s
fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:511s
fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:433s
fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:606s
fi-hsw-4770 total:279 pass:261 dwarn:0 dfail:0 fail:2 skip:16 time:461s
fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:428s
fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:427s
fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:501s
fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s
fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:475s
fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:598s
fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:595s
fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:516s
fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:469s
fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s
fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:483s
fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:442s
fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:499s
fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:548s
fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:410s
00b77f621f835bc114b79ec897b9aa277ea5726b drm-tip: 2017y-08m-28d-10h-25m-08s UTC integration manifest
e19ac29f9da6 drm/i915: Beef up of Beef up the IPS vs. CRC workaround
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5509/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915: Beef up of Beef up the IPS vs. CRC workaround
2017-08-28 12:18 ` [PATCH v2] " Marta Lofstedt
@ 2017-08-28 14:40 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2017-08-28 14:40 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
On Mon, Aug 28, 2017 at 03:18:10PM +0300, Marta Lofstedt wrote:
> Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was
I fixed that commit reference to use the correct format and pushed the
patch to dinq. Thanks for fixing my mess.
> supposed to solve below bug. However, the patch I tested
> is not the same as the one that got merged.
> With this addition the test pass.
>
> V2: removed unused: "struct intel_crtc *intel_crtc"
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101664
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pipe_crc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
> index 4e22bb927fed..96043a51c1bf 100644
> --- a/drivers/gpu/drm/i915/intel_pipe_crc.c
> +++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
> @@ -919,7 +919,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name,
> {
> struct drm_i915_private *dev_priv = crtc->dev->dev_private;
> struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[crtc->index];
> - struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
> enum intel_display_power_domain power_domain;
> enum intel_pipe_crc_source source;
> u32 val = 0; /* shut up gcc */
> @@ -951,8 +950,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name,
> else if ((IS_HASWELL(dev_priv) ||
> IS_BROADWELL(dev_priv)) && crtc->index == PIPE_A)
> hsw_pipe_A_crc_wa(dev_priv, false);
> -
> - hsw_enable_ips(intel_crtc);
> }
>
> pipe_crc->skipped = 0;
> --
> 2.11.0
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)
2017-08-28 11:34 [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround Marta Lofstedt
` (2 preceding siblings ...)
2017-08-28 12:29 ` ✓ Fi.CI.BAT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2) Patchwork
@ 2017-08-28 14:42 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2017-08-28 14:42 UTC (permalink / raw)
To: Marta Lofstedt; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)
URL : https://patchwork.freedesktop.org/series/29425/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test perf:
Subgroup polling:
pass -> FAIL (shard-hsw) fdo#102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2230 pass:1230 dwarn:0 dfail:0 fail:18 skip:982 time:9636s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5509/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-28 14:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 11:34 [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround Marta Lofstedt
2017-08-28 11:49 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-08-28 12:18 ` [PATCH v2] " Marta Lofstedt
2017-08-28 14:40 ` Ville Syrjälä
2017-08-28 12:29 ` ✓ Fi.CI.BAT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2) Patchwork
2017-08-28 14:42 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.