From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751349AbdH1OQL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Aug 2017 10:16:11 -0400
Received: from mail.kernel.org ([198.145.29.99]:47484 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751161AbdH1OQK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Aug 2017 10:16:10 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D40702199F
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Mon, 28 Aug 2017 11:16:07 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: David Carrillo-Cisneros <davidcc@google.com>,
        linux-kernel@vger.kernel.org,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Subject: Re: [PATCH 0/6] perf tools: Minor build fixes
Message-ID: <20170828141607.GI10477@kernel.org>
References: <20170827075442.108534-1-davidcc@google.com>
 <20170828093421.GB15692@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170828093421.GB15692@krava>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Aug 28, 2017 at 11:34:21AM +0200, Jiri Olsa escreveu:
> On Sun, Aug 27, 2017 at 12:54:36AM -0700, David Carrillo-Cisneros wrote:
> > Collection of minor fixes to compile with LLVM and
> > non-standard tool names.
> > 
> > David Carrillo-Cisneros (6):
> >   tools build tests: Don't hardcode gcc name
> >   perf tools: Allow external definition of flex and bison binary names
> >   tools lib: Allow external definition of CC, AR and LD
> >   perf tools: Robustify detection of clang binary
> >   perf tools: Remove BUG_ON char[] to bool implicit conversions
> >   perf tools: Pass full path of FEATURES_DUMP
> 
> apart from comment for 5/6 I'm ok with this
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied all that Jiri acked, agree with him that BUG should be
avoided, and also that we should use existing facilities when available,
and when there aren't, try to replicate as best as we can similar
facilities existing in the kernel source code.

- Arnaldo