From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 28 Aug 2017 22:55:41 -0400 Subject: [U-Boot] [U-Boot, 02/14] nvme: Fix getting PCI vendor id of the NVMe block device In-Reply-To: <1503414919-30820-3-git-send-email-bmeng.cn@gmail.com> References: <1503414919-30820-3-git-send-email-bmeng.cn@gmail.com> Message-ID: <20170829025541.GH17058@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 22, 2017 at 08:15:07AM -0700, Bin Meng wrote: > The codes currently try to read PCI vendor id of the NVMe block > device by dm_pci_read_config16() with its parameter set as its > root complex controller (ndev->pdev) instead of itself. This is > seriously wrong. We can read the vendor id by passing the correct > udevice parameter to the dm_pci_read_config16() API, however there > is a shortcut by reading the cached vendor id from the PCI device's > struct pci_child_platdata. > > While we are here fixing this bug, apparently the quirk stuff handle > codes in nvme_get_info_from_identify() never takes effect since its > logic has never been true at all. Remove these codes completely. > > Signed-off-by: Bin Meng Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: