From: Wei Liu <wei.liu2@citrix.com>
To: Daniel Sabogal <dsabogalcc@gmail.com>
Cc: xen-devel@lists.xenproject.org, julien.grall@arm.com,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] libxl/arm: Fix build on arm64 + acpi
Date: Tue, 29 Aug 2017 11:04:16 +0100 [thread overview]
Message-ID: <20170829100416.oj3ufnbiodierpqw@citrix.com> (raw)
In-Reply-To: <20170828172750.yeu55kic7xriozpo@citrix.com>
On Mon, Aug 28, 2017 at 06:27:51PM +0100, Wei Liu wrote:
> On Fri, Aug 25, 2017 at 05:35:47PM -0400, Daniel Sabogal wrote:
> > With musl, the build fails with the following errors:
> >
> > actypes.h:202:2: error: #error unknown ACPI_MACHINE_WIDTH
> > #error unknown ACPI_MACHINE_WIDTH
> > ^~~~~
> > actypes.h:207:9: error: unknown type name ‘acpi_native_uint’
> > typedef acpi_native_uint acpi_size;
> > ^~~~~~~~~~~~~~~~
> > actypes.h:617:3: error: unknown type name ‘acpi_io_address’
> > acpi_io_address pblk_address;
> > ^~~~~~~~~~~~~~~
> >
> > This likely went undetected with glibc builds since glibc
> > indirectly pulls __BITS_PER_LONG from the linux headers
> > through a standard header. For musl, this is not the case.
> >
> > Instead, use BITS_PER_LONG to fix the build.
> >
> > Signed-off-by: Daniel Sabogal <dsabogalcc@gmail.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Now applied.
Ian, please backport this.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-29 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 21:35 [PATCH] libxl/arm: Fix build on arm64 + acpi Daniel Sabogal
2017-08-28 17:27 ` Wei Liu
2017-08-29 10:04 ` Wei Liu [this message]
2017-08-29 10:10 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829100416.oj3ufnbiodierpqw@citrix.com \
--to=wei.liu2@citrix.com \
--cc=dsabogalcc@gmail.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.