All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marta Lofstedt <marta.lofstedt@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC
Date: Tue, 29 Aug 2017 13:32:43 +0300	[thread overview]
Message-ID: <20170829103243.2662-1-marta.lofstedt@intel.com> (raw)

Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_params.
This leads to segfault on machines where the subtest should be skipped.

Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>
---
 tests/kms_atomic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index d77a526f..042a7c26 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -1596,6 +1596,7 @@ igt_main
 		struct kms_atomic_connector_state *conn =
 			find_connector(scratch, crtc);
 
+		igt_require(crtc);
 		igt_require(plane);
 		igt_require(conn);
 		atomic_invalid_params(crtc, plane, conn);
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2017-08-29 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 10:32 Marta Lofstedt [this message]
2017-08-29 10:49 ` Mika Kahola
2017-08-30  8:06   ` Arkadiusz Hiler
2017-08-29 11:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-29 12:25 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829103243.2662-1-marta.lofstedt@intel.com \
    --to=marta.lofstedt@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --subject='Re: [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.