From: Michal Kubecek <email@example.com>
To: Tariq Toukan <firstname.lastname@example.org>
Cc: "John W. Linville" <email@example.com>,
Eric Dumazet <firstname.lastname@example.org>,
David Miller <email@example.com>,
firstname.lastname@example.org, Eran Ben Elisha <email@example.com>,
Shaker Daibes <firstname.lastname@example.org>
Subject: Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool
Date: Tue, 29 Aug 2017 12:44:53 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
On Tue, Aug 29, 2017 at 10:50:20AM +0300, Tariq Toukan wrote:
> On 28/08/2017 9:22 PM, John W. Linville wrote:
> > On Mon, Aug 28, 2017 at 08:00:11AM -0700, Eric Dumazet wrote:
> > > On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote:
> > > > From: Shaker Daibes <firstname.lastname@example.org>
> > > >
> > > > UFO was removed in kernel, here we remove it in ethtool app.
> > > >
> > > > Fixes the following issue:
> > > > Features for ens8:
> > > > Cannot get device udp-fragmentation-offload settings: Operation not supported
> But I wonder how the warning removal should be done??
> I have some suggestions in mind:
> 1) Have a special condition that does not print a warning only in the case
> of UFO?
> 2) Remove the warning totally? I don't like this option.
> 3) Add a max_kernel_ver field in struct off_flag_def, and use it to not
> print the warning, or to mark the feature 'off [fixed]'.
IMHO there is nothing wrong with not writing a warning for "get"
operation, after all it's just "ethtool -k", i.e. "show me all
offloading flags" and we do not warn about unsupported named features
either. IMHO the only question should be how friendly we should be to
old scripts expecting the line in the output:
(a) omit the "udp-fragmentation-offload:" line (be consistent)
(b) say something like "udp-fragmentation-offload: n/a"
(c) pretend it's there and is off (most careful but misleading)
Personally, I would prefer (a) but some badly written scripts might have
problem with this approach.
On the other hand, an attempt to _set_ the flag with "ethtool -K" should
issue an error.
next prev parent reply other threads:[~2017-08-29 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 12:38 [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool Tariq Toukan
2017-08-28 15:00 ` Eric Dumazet
2017-08-28 16:38 ` David Miller
2017-08-28 18:22 ` John W. Linville
2017-08-29 7:50 ` Tariq Toukan
2017-08-29 10:44 ` Michal Kubecek [this message]
2017-09-04 11:46 ` Tariq Toukan
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.