From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbdH2LgP (ORCPT ); Tue, 29 Aug 2017 07:36:15 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:47966 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbdH2LgN (ORCPT ); Tue, 29 Aug 2017 07:36:13 -0400 Date: Tue, 29 Aug 2017 07:35:58 -0400 From: Neil Horman To: Wolfram Sang Cc: Stephen Douthit , seth.heasley@intel.com, danp@adiengineering.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Message-ID: <20170829113558.GA5406@hmswarspite.think-freely.org> References: <1502140260-13789-1-git-send-email-stephend@adiengineering.com> <20170814193105.cosdlbf5gypazlzn@ninjato> <20170829102225.7yjh52hivygbdbc7@ninjato> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170829102225.7yjh52hivygbdbc7@ninjato> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 12:22:25PM +0200, Wolfram Sang wrote: > > > >> So basically the byte count already precedes the data in the dma_buffer, > > >> then the driver sticks desc->rxbytes in front of this resulting in the > > >> trace above. > > >> > > >> The first patch tackles this. > > >> > > >> The second patch in the series adds a sanity check on the byte count > > >> supplied by the slave device. This might be a nice to have, but is > > >> probably less critical. > > > > > > Both patches look good to me. Seth, Neil, do you agree? > > > > > > > Ping. > > > > Not sure what the usual review time is, let me know if this is premature. > > I applied both patches to for-next (v4.14) now to get a broader > audience. for-current (v4.13) might have been also applicable, but I > don't want to apply the patches there without the driver maintainer > acks. I hope this works for you. > Sorry, I've been on vacation, yes, the patches look good to me Acked-by: Neil Horman