* [PATCH] ACPI / hotplug / PCI: Drop unnecessary parentheses
@ 2017-08-29 11:56 Mika Westerberg
2017-08-29 14:51 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Mika Westerberg @ 2017-08-29 11:56 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, Bjorn Helgaas, Mika Westerberg, linux-acpi
There is no need for them and it makes the code look uglier than it
should. Remove them.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/pci/hotplug/acpiphp_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index 5ed2dcaa8e27..4e07441660e6 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -527,7 +527,7 @@ static void disable_slot(struct acpiphp_slot *slot)
list_for_each_entry(func, &slot->funcs, sibling)
acpi_bus_trim(func_to_acpi_device(func));
- slot->flags &= (~SLOT_ENABLED);
+ slot->flags &= ~SLOT_ENABLED;
}
static bool slot_no_hotplug(struct acpiphp_slot *slot)
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI / hotplug / PCI: Drop unnecessary parentheses
2017-08-29 11:56 [PATCH] ACPI / hotplug / PCI: Drop unnecessary parentheses Mika Westerberg
@ 2017-08-29 14:51 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-08-29 14:51 UTC (permalink / raw)
To: Mika Westerberg, Bjorn Helgaas; +Cc: Len Brown, linux-acpi
On Tuesday, August 29, 2017 1:56:05 PM CEST Mika Westerberg wrote:
> There is no need for them and it makes the code look uglier than it
> should. Remove them.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/pci/hotplug/acpiphp_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
> index 5ed2dcaa8e27..4e07441660e6 100644
> --- a/drivers/pci/hotplug/acpiphp_glue.c
> +++ b/drivers/pci/hotplug/acpiphp_glue.c
> @@ -527,7 +527,7 @@ static void disable_slot(struct acpiphp_slot *slot)
> list_for_each_entry(func, &slot->funcs, sibling)
> acpi_bus_trim(func_to_acpi_device(func));
>
> - slot->flags &= (~SLOT_ENABLED);
> + slot->flags &= ~SLOT_ENABLED;
> }
>
> static bool slot_no_hotplug(struct acpiphp_slot *slot)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 11:56 [PATCH] ACPI / hotplug / PCI: Drop unnecessary parentheses Mika Westerberg
2017-08-29 14:51 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.