From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors Date: Tue, 29 Aug 2017 07:27:20 -0700 Message-ID: <20170829142720.GI491396@devbig577.frc2.facebook.com> References: <3117ae58-d432-101e-3f0b-68d72fdee28b@gmail.com> <20170828195916.GA491396@devbig577.frc2.facebook.com> <37033f6d-2ad0-7817-10b5-cbd7ff565624@gmail.com> <20170828212225.GB491396@devbig577.frc2.facebook.com> <20170829124206.GA26738@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170829124206.GA26738@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: David Ahern , linux-ide@vger.kernel.org, LKML , Robert Elliott List-Id: linux-ide@vger.kernel.org Hello, On Tue, Aug 29, 2017 at 02:42:06PM +0200, Christoph Hellwig wrote: > We could try to check the IDENTIFY DEVICE word, but given that it has > a dual meaning in older spec versions I don't really like the idea > either. Untested patch below as I'm not near my OPAL capable drive. I see. > Also most recent ATA features seem to be keyed off a log page of some > sort, so we'll run into more problems like this. :( > From e661047ec3a25587648b07c02a687a7dac778f3b Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Tue, 29 Aug 2017 14:35:50 +0200 > Subject: libata: check for trusted computing in IDENTIFY DEVICE data > > ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of > the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE > command to avoid issues with buggy devices. The only downside is that > we can't support Security Send / Receive for a device with an older > revision due to the conflicting use of this field in earlier > specifications. > > Signed-off-by: Christoph Hellwig David, can you please see whether this patch resolves your issue? Thanks. -- tejun