All of lore.kernel.org
 help / color / mirror / Atom feed
* [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo
@ 2017-08-29 16:38 Manisha Agrawal
  2017-08-29 16:38 ` [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo Manisha Agrawal
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

Recipe to build EVSE HMI demo. EVSE stands for electronic vehicle
supply station.  This demo is created as part of TID on EVSE to
demonsrate drawing the gui for EVSE application using QT QWidget and
rendering on LCD panel using  linuxfb QPA.

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 .../recipes-apps/evse-hmi/evse-hmi_git.bb            | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100755 meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb

diff --git a/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb b/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb
new file mode 100755
index 0000000..4c7c8c6
--- /dev/null
+++ b/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb
@@ -0,0 +1,20 @@
+DESCRIPTION = "HMI demo for electronic vehicle charging station (EVSE) using QT QWidget tools"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://main.cpp;beginline=1;endline=33;md5=a9cde3921a8be42ed79ab74661799104"
+
+inherit qt-provider
+
+PV = "01.00.00"
+PR = "r1"
+
+BRANCH = "master"
+SRC_URI = "git://git.ti.com/sitara-linux/evse-hmi.git;protocol=git;branch=${BRANCH}"
+
+SRCREV = "a257dfc05db311c74cb50838ff5b9e2cfb87dbfe"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+    install -d ${D}${bindir}
+    install -m 755 evse_hmi ${D}${bindir}
+}
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
@ 2017-08-29 16:38 ` Manisha Agrawal
  2017-08-29 17:26   ` Denys Dmytriyenko
  2017-08-29 16:38 ` [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi Manisha Agrawal
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

Create sub menu for HMI
Update the matrix revision for matrix-gui-upadte-v2

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc    | 4 ++--
 meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc b/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
index b805f5e..551416d 100644
--- a/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
@@ -4,9 +4,9 @@ LICENSE_CHECKSUM = "LICENSE;md5=6e0ae7214f6c74c149cb25f373057fa9"
 LIC_FILES_CHKSUM := "file://../${LICENSE_CHECKSUM}"
 
 SRC_URI = "git://git.ti.com/matrix-gui-v2/matrix-gui-v2-apps.git;protocol=git;branch=${BRANCH}"
-SRCREV = "38afccb5335216ececa874cf4cf72a67c4164fc3"
+SRCREV = "50a2f2ec7043e17bc7af72186e3d0a8d7773ec0a"
 BRANCH = "master"
-INC_PR = "r47"
+INC_PR = "r48"
 
 # Pull in the base package for installing matrix applications
 require matrix-gui-apps.inc
diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
index f592f7a..b9973dd 100644
--- a/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
@@ -35,6 +35,7 @@ SUBMENUS = " arm_submenu \
              machinevision_submenu \
              touch_submenu \
              browser_submenu \
+	     hmi_submenu \
 "
 
 do_install(){
@@ -68,6 +69,7 @@ PACKAGES += " ${PN}-arm \
               ${PN}-machinevision \
               ${PN}-touch \
               ${PN}-browser \
+              ${PN}-hmi \
 "
 
 # Make sure app images has been installed
@@ -96,3 +98,4 @@ FILES_${PN}-videoanalytics = "${MATRIX_APP_DIR}/videoanalytics_submenu/*"
 FILES_${PN}-machinevision = "${MATRIX_APP_DIR}/machinevision_submenu/*"
 FILES_${PN}-touch = "${MATRIX_APP_DIR}/touch_submenu/*"
 FILES_${PN}-browser = "${MATRIX_APP_DIR}/browser_submenu/*"
+FILES_${PN}-hmi = "${MATRIX_APP_DIR}/hmi_submenu/*"
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
  2017-08-29 16:38 ` [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo Manisha Agrawal
@ 2017-08-29 16:38 ` Manisha Agrawal
  2017-08-29 17:20   ` Denys Dmytriyenko
  2017-08-29 16:38 ` [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi Manisha Agrawal
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

Recipe to enable adding the evse-hmi demo to the matrix launcher

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 .../matrix/matrix-gui-hmi-demos_2.0.bb             | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100755 meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb

diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb
new file mode 100755
index 0000000..36eaebc
--- /dev/null
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb
@@ -0,0 +1,26 @@
+DESCRIPTION = "HMI demo descriptions for Matrix v2"
+HOMEPAGE = "https://gitorious.org/matrix-gui-v2/matrix-gui-v2-apps"
+
+require recipes-core/matrix/matrix-gui-apps-git.inc
+
+PR = "${INC_PR}.0"
+
+inherit allarch
+
+S = "${WORKDIR}/git/hmi_apps"
+
+# Make sure machinevision submenu and app images has been installed
+HMI_RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-hmi"
+
+FILES_${PN} += "${MATRIX_BASE_DIR}/*"
+
+PACKAGES = "matrix-hmi-demo-evse \
+"
+
+RDEPENDS_matrix-hmi-demo-evse = " \
+    ${HMI_RDEPENDS} \
+    evse-hmi \
+"
+
+FILES_matrix-hmi-demo-evse    = "${MATRIX_APP_DIR}/hmi-evse/*"
+FILES_matrix-hmi-demo-evse  += "${bindir}/runHmiEvse.sh"
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
  2017-08-29 16:38 ` [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo Manisha Agrawal
  2017-08-29 16:38 ` [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi Manisha Agrawal
@ 2017-08-29 16:38 ` Manisha Agrawal
  2017-08-29 17:16   ` Denys Dmytriyenko
  2017-08-29 16:38 ` [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc Manisha Agrawal
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

Create packagegroup for HMI related demos. HMI is one of the focus
growth area for Sitara platform and demos planned for individual target end
equipments. Add evse-hmi demo to the packagegroup.

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
 .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
 create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
new file mode 100755
index 0000000..d58536c
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
@@ -0,0 +1,26 @@
+DESCRIPTION = "Task to add HMI related sources into the SDK"
+LICENSE = "BSD-3-Clause"
+PR = "r1"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+HMI = ""
+
+HMI_append_ti43x = " \
+    evse-hmi-src \
+"
+
+HMI_append_ti33x = " \
+    evse-hmi-src \
+"
+
+
+HMI_append_omap-a15 = " \
+    evse-hmi-src \
+"
+
+RDEPENDS_${PN} = "\
+    ${HMI} \
+"
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
new file mode 100755
index 0000000..9066c72
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
@@ -0,0 +1,27 @@
+DESCRIPTION = "Task to add HMI related packages"
+LICENSE = "BSD-3-Clause"
+PR = "r1"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+inherit packagegroup
+
+HMI = " \
+"
+
+
+HMI_append_ti33x = " \
+    evse-hmi \
+"
+
+HMI_append_ti43x = " \
+    evse-hmi \
+"
+
+HMI_append_omap-a15 = " \
+    evse-hmi \
+"
+
+
+RDEPENDS_${PN} = "\
+"
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
                   ` (2 preceding siblings ...)
  2017-08-29 16:38 ` [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi Manisha Agrawal
@ 2017-08-29 16:38 ` Manisha Agrawal
  2017-08-29 17:32   ` Denys Dmytriyenko
  2017-08-29 16:38 ` [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image Manisha Agrawal
  2017-08-29 17:11 ` [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Denys Dmytriyenko
  5 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

 Add the source code for evse-hmi demo in example-applications of PLSDK.

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 meta-arago-distro/conf/distro/include/arago-source-ipk.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-arago-distro/conf/distro/include/arago-source-ipk.inc b/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
index c598d5d..5dd1ca6 100644
--- a/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
+++ b/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
@@ -67,6 +67,9 @@ SRCIPK_INSTALL_DIR_pn-qt-tstat = "example-applications/${PN}-${PV}"
 CREATE_SRCIPK_pn-dual-camera-demo = "1"
 SRCIPK_INSTALL_DIR_pn-dual-camera-demo = "example-applications/${PN}-${PV}"
 
+CREATE_SRCIPK_pn-evse-hmi = "1"
+SRCIPK_INSTALL_DIR_pn-evse-hmi = "example-applications/${PN}-${PV}"
+
 CREATE_SRCIPK_pn-image-gallery = "1"
 SRCIPK_INSTALL_DIR_pn-image-gallery = "example-applications/${PN}"
 
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
                   ` (3 preceding siblings ...)
  2017-08-29 16:38 ` [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc Manisha Agrawal
@ 2017-08-29 16:38 ` Manisha Agrawal
  2017-08-29 17:29   ` Denys Dmytriyenko
  2017-08-29 17:11 ` [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Denys Dmytriyenko
  5 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 16:38 UTC (permalink / raw)
  To: meta-arago

Add evse-hmi image to the rootfs.

Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
---
 meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb b/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
index 1a477d1..e40dc1f 100644
--- a/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
+++ b/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
@@ -20,6 +20,7 @@ IMAGE_INSTALL += "\
     packagegroup-arago-tisdk-amsdk \
     packagegroup-arago-tisdk-addons \
     packagegroup-arago-tisdk-addons-extra \
+    packagegroup-arago-tisdk-hmi \
     "
 
 export IMAGE_BASENAME = "tisdk-rootfs-image"
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo
  2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
                   ` (4 preceding siblings ...)
  2017-08-29 16:38 ` [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image Manisha Agrawal
@ 2017-08-29 17:11 ` Denys Dmytriyenko
  5 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:11 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

Manisha,

https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Headers_and_Commit_Messages

Change Subject from:

> meta-arago-extras : recipe-apps : evse-hmi : new demo

To:

> evse-hmi: add new demo


> Recipe to build EVSE HMI demo.

Please drop this sentence ^^^


> EVSE stands for electronic vehicle
> supply station.  This demo is created as part of TID on EVSE to
> demonsrate drawing the gui for EVSE application using QT QWidget and
> rendering on LCD panel using  linuxfb QPA.
> 
> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  .../recipes-apps/evse-hmi/evse-hmi_git.bb            | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100755 meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb
> 
> diff --git a/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb b/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb
> new file mode 100755
> index 0000000..4c7c8c6
> --- /dev/null
> +++ b/meta-arago-extras/recipes-apps/evse-hmi/evse-hmi_git.bb
> @@ -0,0 +1,20 @@
> +DESCRIPTION = "HMI demo for electronic vehicle charging station (EVSE) using QT QWidget tools"

SUMMARY is missing:
https://lists.yoctoproject.org/pipermail/meta-ti/2017-July/010261.html


> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://main.cpp;beginline=1;endline=33;md5=a9cde3921a8be42ed79ab74661799104"
> +
> +inherit qt-provider
> +
> +PV = "01.00.00"
> +PR = "r1"
> +
> +BRANCH = "master"
> +SRC_URI = "git://git.ti.com/sitara-linux/evse-hmi.git;protocol=git;branch=${BRANCH}"
> +
> +SRCREV = "a257dfc05db311c74cb50838ff5b9e2cfb87dbfe"
> +
> +S = "${WORKDIR}/git"
> +
> +do_install() {
> +    install -d ${D}${bindir}
> +    install -m 755 evse_hmi ${D}${bindir}
> +}
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 16:38 ` [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi Manisha Agrawal
@ 2017-08-29 17:16   ` Denys Dmytriyenko
  2017-08-29 19:55     ` Denys Dmytriyenko
  0 siblings, 1 reply; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:16 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

Manisha,

From this:

> recipes-core : packagegroups: hmi

To this:

> packagegroup-*-hmi: add hmi specific packagegroups


On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
> Create packagegroup for HMI related demos. HMI is one of the focus
> growth area for Sitara platform and demos planned for individual target end
> equipments. Add evse-hmi demo to the packagegroup.
> 
> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
>  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
>  2 files changed, 53 insertions(+)
>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> new file mode 100755
> index 0000000..d58536c
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "Task to add HMI related sources into the SDK"

SUMMARY is missing.


> +LICENSE = "BSD-3-Clause"

By default all OE metadata is licensed under MIT. Unless you have a very 
specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.


> +PR = "r1"

Not critical, but PR can also be omitted for new recipes.


> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +HMI = ""
> +
> +HMI_append_ti43x = " \
> +    evse-hmi-src \
> +"
> +
> +HMI_append_ti33x = " \
> +    evse-hmi-src \
> +"
> +
> +
> +HMI_append_omap-a15 = " \
> +    evse-hmi-src \
> +"
> +
> +RDEPENDS_${PN} = "\
> +    ${HMI} \
> +"
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> new file mode 100755
> index 0000000..9066c72
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> @@ -0,0 +1,27 @@

Same comments here.


> +DESCRIPTION = "Task to add HMI related packages"
> +LICENSE = "BSD-3-Clause"
> +PR = "r1"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +inherit packagegroup
> +
> +HMI = " \
> +"
> +
> +
> +HMI_append_ti33x = " \
> +    evse-hmi \
> +"
> +
> +HMI_append_ti43x = " \
> +    evse-hmi \
> +"
> +
> +HMI_append_omap-a15 = " \
> +    evse-hmi \
> +"
> +
> +
> +RDEPENDS_${PN} = "\
> +"
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi
  2017-08-29 16:38 ` [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi Manisha Agrawal
@ 2017-08-29 17:20   ` Denys Dmytriyenko
  0 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:20 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

> meta-arago-extras : matrix : recipe for evse hmi

> matrix-gui-hmi-demos: hmi demo descriptions for matrix


> Recipe to enable adding the evse-hmi demo to the matrix launcher

This is redundant if the above subject is used.


> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  .../matrix/matrix-gui-hmi-demos_2.0.bb             | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100755 meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb
> 
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb
> new file mode 100755
> index 0000000..36eaebc
> --- /dev/null
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-hmi-demos_2.0.bb
> @@ -0,0 +1,26 @@
> +DESCRIPTION = "HMI demo descriptions for Matrix v2"

SUMMARY.


> +HOMEPAGE = "https://gitorious.org/matrix-gui-v2/matrix-gui-v2-apps"
> +
> +require recipes-core/matrix/matrix-gui-apps-git.inc
> +
> +PR = "${INC_PR}.0"
> +
> +inherit allarch
> +
> +S = "${WORKDIR}/git/hmi_apps"
> +
> +# Make sure machinevision submenu and app images has been installed
> +HMI_RDEPENDS += "matrix-gui-apps-images matrix-gui-submenus-hmi"
> +
> +FILES_${PN} += "${MATRIX_BASE_DIR}/*"
> +
> +PACKAGES = "matrix-hmi-demo-evse \
> +"
> +
> +RDEPENDS_matrix-hmi-demo-evse = " \
> +    ${HMI_RDEPENDS} \
> +    evse-hmi \
> +"
> +
> +FILES_matrix-hmi-demo-evse    = "${MATRIX_APP_DIR}/hmi-evse/*"
> +FILES_matrix-hmi-demo-evse  += "${bindir}/runHmiEvse.sh"
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo
  2017-08-29 16:38 ` [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo Manisha Agrawal
@ 2017-08-29 17:26   ` Denys Dmytriyenko
  0 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:26 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

This one looks good, thanks.


On Tue, Aug 29, 2017 at 11:38:22AM -0500, Manisha Agrawal wrote:
> Create sub menu for HMI
> Update the matrix revision for matrix-gui-upadte-v2
> 
> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc    | 4 ++--
>  meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb | 3 +++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc b/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
> index b805f5e..551416d 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-apps-git.inc
> @@ -4,9 +4,9 @@ LICENSE_CHECKSUM = "LICENSE;md5=6e0ae7214f6c74c149cb25f373057fa9"
>  LIC_FILES_CHKSUM := "file://../${LICENSE_CHECKSUM}"
>  
>  SRC_URI = "git://git.ti.com/matrix-gui-v2/matrix-gui-v2-apps.git;protocol=git;branch=${BRANCH}"
> -SRCREV = "38afccb5335216ececa874cf4cf72a67c4164fc3"
> +SRCREV = "50a2f2ec7043e17bc7af72186e3d0a8d7773ec0a"
>  BRANCH = "master"
> -INC_PR = "r47"
> +INC_PR = "r48"
>  
>  # Pull in the base package for installing matrix applications
>  require matrix-gui-apps.inc
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
> index f592f7a..b9973dd 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui-submenus_2.0.bb
> @@ -35,6 +35,7 @@ SUBMENUS = " arm_submenu \
>               machinevision_submenu \
>               touch_submenu \
>               browser_submenu \
> +	     hmi_submenu \
>  "
>  
>  do_install(){
> @@ -68,6 +69,7 @@ PACKAGES += " ${PN}-arm \
>                ${PN}-machinevision \
>                ${PN}-touch \
>                ${PN}-browser \
> +              ${PN}-hmi \
>  "
>  
>  # Make sure app images has been installed
> @@ -96,3 +98,4 @@ FILES_${PN}-videoanalytics = "${MATRIX_APP_DIR}/videoanalytics_submenu/*"
>  FILES_${PN}-machinevision = "${MATRIX_APP_DIR}/machinevision_submenu/*"
>  FILES_${PN}-touch = "${MATRIX_APP_DIR}/touch_submenu/*"
>  FILES_${PN}-browser = "${MATRIX_APP_DIR}/browser_submenu/*"
> +FILES_${PN}-hmi = "${MATRIX_APP_DIR}/hmi_submenu/*"
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image
  2017-08-29 16:38 ` [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image Manisha Agrawal
@ 2017-08-29 17:29   ` Denys Dmytriyenko
  0 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:29 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

Change subject:

> arago-distro : recipes-core : tisdk-rootfs-image

> tisdk-rootfs-image: add evse-hmi packagegroup


> Add evse-hmi image to the rootfs.

If you change subject like above, this won't be needed.


> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb b/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
> index 1a477d1..e40dc1f 100644
> --- a/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
> +++ b/meta-arago-distro/recipes-core/images/tisdk-rootfs-image.bb
> @@ -20,6 +20,7 @@ IMAGE_INSTALL += "\
>      packagegroup-arago-tisdk-amsdk \
>      packagegroup-arago-tisdk-addons \
>      packagegroup-arago-tisdk-addons-extra \
> +    packagegroup-arago-tisdk-hmi \
>      "
>  
>  export IMAGE_BASENAME = "tisdk-rootfs-image"
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc
  2017-08-29 16:38 ` [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc Manisha Agrawal
@ 2017-08-29 17:32   ` Denys Dmytriyenko
  0 siblings, 0 replies; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 17:32 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

Same comment about the subject.

Basically, the commit log in over-simplified form looks like:

=================
where: what changed

why the change is needed

sign-offs:
=================


On Tue, Aug 29, 2017 at 11:38:25AM -0500, Manisha Agrawal wrote:
>  Add the source code for evse-hmi demo in example-applications of PLSDK.
> 
> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> ---
>  meta-arago-distro/conf/distro/include/arago-source-ipk.inc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-arago-distro/conf/distro/include/arago-source-ipk.inc b/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
> index c598d5d..5dd1ca6 100644
> --- a/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
> +++ b/meta-arago-distro/conf/distro/include/arago-source-ipk.inc
> @@ -67,6 +67,9 @@ SRCIPK_INSTALL_DIR_pn-qt-tstat = "example-applications/${PN}-${PV}"
>  CREATE_SRCIPK_pn-dual-camera-demo = "1"
>  SRCIPK_INSTALL_DIR_pn-dual-camera-demo = "example-applications/${PN}-${PV}"
>  
> +CREATE_SRCIPK_pn-evse-hmi = "1"
> +SRCIPK_INSTALL_DIR_pn-evse-hmi = "example-applications/${PN}-${PV}"
> +
>  CREATE_SRCIPK_pn-image-gallery = "1"
>  SRCIPK_INSTALL_DIR_pn-image-gallery = "example-applications/${PN}"
>  
> -- 
> 2.13.0
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 17:16   ` Denys Dmytriyenko
@ 2017-08-29 19:55     ` Denys Dmytriyenko
  2017-08-29 20:56       ` Manisha Agrawal
  0 siblings, 1 reply; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 19:55 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

On Tue, Aug 29, 2017 at 01:16:59PM -0400, Denys Dmytriyenko wrote:
> Manisha,
> 
> From this:
> 
> > recipes-core : packagegroups: hmi
> 
> To this:
> 
> > packagegroup-*-hmi: add hmi specific packagegroups
> 
> 
> On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
> > Create packagegroup for HMI related demos. HMI is one of the focus
> > growth area for Sitara platform and demos planned for individual target end
> > equipments. Add evse-hmi demo to the packagegroup.
> > 
> > Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> > ---
> >  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
> >  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
> >  2 files changed, 53 insertions(+)
> >  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> > 
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> > new file mode 100755
> > index 0000000..d58536c
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> > @@ -0,0 +1,26 @@
> > +DESCRIPTION = "Task to add HMI related sources into the SDK"
> 
> SUMMARY is missing.
> 
> 
> > +LICENSE = "BSD-3-Clause"
> 
> By default all OE metadata is licensed under MIT. Unless you have a very 
> specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
> BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.
> 
> 
> > +PR = "r1"
> 
> Not critical, but PR can also be omitted for new recipes.
> 
> 
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +inherit packagegroup
> > +
> > +HMI = ""
> > +
> > +HMI_append_ti43x = " \
> > +    evse-hmi-src \
> > +"
> > +
> > +HMI_append_ti33x = " \
> > +    evse-hmi-src \
> > +"
> > +
> > +
> > +HMI_append_omap-a15 = " \
> > +    evse-hmi-src \
> > +"
> > +
> > +RDEPENDS_${PN} = "\
> > +    ${HMI} \
> > +"
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> > new file mode 100755
> > index 0000000..9066c72
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> > @@ -0,0 +1,27 @@
> 
> Same comments here.
> 
> 
> > +DESCRIPTION = "Task to add HMI related packages"
> > +LICENSE = "BSD-3-Clause"
> > +PR = "r1"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +inherit packagegroup
> > +
> > +HMI = " \
> > +"
> > +
> > +
> > +HMI_append_ti33x = " \
> > +    evse-hmi \
> > +"
> > +
> > +HMI_append_ti43x = " \
> > +    evse-hmi \
> > +"
> > +
> > +HMI_append_omap-a15 = " \
> > +    evse-hmi \
> > +"
> > +
> > +
> > +RDEPENDS_${PN} = "\
> > +"

Also, you seem to be missing to add anything in RDEPENDS...


> > -- 
> > 2.13.0
> > 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 19:55     ` Denys Dmytriyenko
@ 2017-08-29 20:56       ` Manisha Agrawal
  2017-08-29 21:05         ` Denys Dmytriyenko
  0 siblings, 1 reply; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 20:56 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-arago



On 08/29/2017 02:55 PM, Denys Dmytriyenko wrote:
> On Tue, Aug 29, 2017 at 01:16:59PM -0400, Denys Dmytriyenko wrote:
>> Manisha,
>>
>> From this:
>>
>>> recipes-core : packagegroups: hmi
>> To this:
>>
>>> packagegroup-*-hmi: add hmi specific packagegroups
>>
>> On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
>>> Create packagegroup for HMI related demos. HMI is one of the focus
>>> growth area for Sitara platform and demos planned for individual target end
>>> equipments. Add evse-hmi demo to the packagegroup.
>>>
>>> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
>>> ---
>>>  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
>>>  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
>>>  2 files changed, 53 insertions(+)
>>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>>
>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>> new file mode 100755
>>> index 0000000..d58536c
>>> --- /dev/null
>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>> @@ -0,0 +1,26 @@
>>> +DESCRIPTION = "Task to add HMI related sources into the SDK"
>> SUMMARY is missing.
I see either SUMMARY or DESCRIPTION in other packagefroup files. Do you
want me to rename the DESCRIPTION as SUMMARY or you want to see more
information as part of SUMMARY. If yes, what additional information
should I add there.
>>
>>> +LICENSE = "BSD-3-Clause"
This was suggested by Vivek. His comment was "Any user-space demo
applications that we develop should be in TI BSD-3-clause license, as
that’s the most friendliest and can be used by others (RTOS, VxWorks,
etc.)…"


>> By default all OE metadata is licensed under MIT. Unless you have a very 
>> specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
>> BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.
>>
>>
>>> +PR = "r1"
>> Not critical, but PR can also be omitted for new recipes.

I am keeping it for now else in future I will forget to add the
revision. If I keep it, would you suggest it to be "r0" or "r1".
>>
>>
>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> +
>>> +inherit packagegroup
>>> +
>>> +HMI = ""
>>> +
>>> +HMI_append_ti43x = " \
>>> +    evse-hmi-src \
>>> +"
>>> +
>>> +HMI_append_ti33x = " \
>>> +    evse-hmi-src \
>>> +"
>>> +
>>> +
>>> +HMI_append_omap-a15 = " \
>>> +    evse-hmi-src \
>>> +"
>>> +
>>> +RDEPENDS_${PN} = "\
>>> +    ${HMI} \
>>> +"
>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>> new file mode 100755
>>> index 0000000..9066c72
>>> --- /dev/null
>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>> @@ -0,0 +1,27 @@
>> Same comments here.
>>
>>
>>> +DESCRIPTION = "Task to add HMI related packages"
>>> +LICENSE = "BSD-3-Clause"
>>> +PR = "r1"
>>> +
>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>> +
>>> +inherit packagegroup
>>> +
>>> +HMI = " \
>>> +"
>>> +
>>> +
>>> +HMI_append_ti33x = " \
>>> +    evse-hmi \
>>> +"
>>> +
>>> +HMI_append_ti43x = " \
>>> +    evse-hmi \
>>> +"
>>> +
>>> +HMI_append_omap-a15 = " \
>>> +    evse-hmi \
>>> +"
>>> +
>>> +
>>> +RDEPENDS_${PN} = "\
>>> +"
> Also, you seem to be missing to add anything in RDEPENDS...
>
>
>>> -- 
>>> 2.13.0
>>>
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 20:56       ` Manisha Agrawal
@ 2017-08-29 21:05         ` Denys Dmytriyenko
  2017-08-29 21:17           ` Manisha Agrawal
  0 siblings, 1 reply; 16+ messages in thread
From: Denys Dmytriyenko @ 2017-08-29 21:05 UTC (permalink / raw)
  To: Manisha Agrawal; +Cc: meta-arago

On Tue, Aug 29, 2017 at 03:56:56PM -0500, Manisha Agrawal wrote:
> 
> 
> On 08/29/2017 02:55 PM, Denys Dmytriyenko wrote:
> > On Tue, Aug 29, 2017 at 01:16:59PM -0400, Denys Dmytriyenko wrote:
> >> Manisha,
> >>
> >> From this:
> >>
> >>> recipes-core : packagegroups: hmi
> >> To this:
> >>
> >>> packagegroup-*-hmi: add hmi specific packagegroups
> >>
> >> On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
> >>> Create packagegroup for HMI related demos. HMI is one of the focus
> >>> growth area for Sitara platform and demos planned for individual target end
> >>> equipments. Add evse-hmi demo to the packagegroup.
> >>>
> >>> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
> >>> ---
> >>>  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
> >>>  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
> >>>  2 files changed, 53 insertions(+)
> >>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>>
> >>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>> new file mode 100755
> >>> index 0000000..d58536c
> >>> --- /dev/null
> >>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
> >>> @@ -0,0 +1,26 @@
> >>> +DESCRIPTION = "Task to add HMI related sources into the SDK"
> >> SUMMARY is missing.
> I see either SUMMARY or DESCRIPTION in other packagefroup files. Do you
> want me to rename the DESCRIPTION as SUMMARY or you want to see more
> information as part of SUMMARY. If yes, what additional information
> should I add there.

Please see my comment for patch #1 with the link.


> >>> +LICENSE = "BSD-3-Clause"
> 
> >> By default all OE metadata is licensed under MIT. Unless you have a very 
> >> specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
> >> BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.

> This was suggested by Vivek. His comment was "Any user-space demo
> applications that we develop should be in TI BSD-3-clause license, as
> that’s the most friendliest and can be used by others (RTOS, VxWorks,
> etc.)…"

A packagegroup is not a user-space demo application, hence my comment above.


> >>> +PR = "r1"
> >> Not critical, but PR can also be omitted for new recipes.
> 
> I am keeping it for now else in future I will forget to add the
> revision. If I keep it, would you suggest it to be "r0" or "r1".

Doesn't matter, but it defaults to "r0".


> >>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>> +
> >>> +inherit packagegroup
> >>> +
> >>> +HMI = ""
> >>> +
> >>> +HMI_append_ti43x = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +HMI_append_ti33x = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +
> >>> +HMI_append_omap-a15 = " \
> >>> +    evse-hmi-src \
> >>> +"
> >>> +
> >>> +RDEPENDS_${PN} = "\
> >>> +    ${HMI} \
> >>> +"
> >>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>> new file mode 100755
> >>> index 0000000..9066c72
> >>> --- /dev/null
> >>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
> >>> @@ -0,0 +1,27 @@
> >> Same comments here.
> >>
> >>
> >>> +DESCRIPTION = "Task to add HMI related packages"
> >>> +LICENSE = "BSD-3-Clause"
> >>> +PR = "r1"
> >>> +
> >>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >>> +
> >>> +inherit packagegroup
> >>> +
> >>> +HMI = " \
> >>> +"
> >>> +
> >>> +
> >>> +HMI_append_ti33x = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +HMI_append_ti43x = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +HMI_append_omap-a15 = " \
> >>> +    evse-hmi \
> >>> +"
> >>> +
> >>> +
> >>> +RDEPENDS_${PN} = "\
> >>> +"
> > Also, you seem to be missing to add anything in RDEPENDS...
> >
> >
> >>> -- 
> >>> 2.13.0
> >>>
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi
  2017-08-29 21:05         ` Denys Dmytriyenko
@ 2017-08-29 21:17           ` Manisha Agrawal
  0 siblings, 0 replies; 16+ messages in thread
From: Manisha Agrawal @ 2017-08-29 21:17 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-arago



On 08/29/2017 04:05 PM, Denys Dmytriyenko wrote:
> On Tue, Aug 29, 2017 at 03:56:56PM -0500, Manisha Agrawal wrote:
>>
>> On 08/29/2017 02:55 PM, Denys Dmytriyenko wrote:
>>> On Tue, Aug 29, 2017 at 01:16:59PM -0400, Denys Dmytriyenko wrote:
>>>> Manisha,
>>>>
>>>> From this:
>>>>
>>>>> recipes-core : packagegroups: hmi
>>>> To this:
>>>>
>>>>> packagegroup-*-hmi: add hmi specific packagegroups
>>>> On Tue, Aug 29, 2017 at 11:38:24AM -0500, Manisha Agrawal wrote:
>>>>> Create packagegroup for HMI related demos. HMI is one of the focus
>>>>> growth area for Sitara platform and demos planned for individual target end
>>>>> equipments. Add evse-hmi demo to the packagegroup.
>>>>>
>>>>> Signed-off-by: Manisha Agrawal <manisha.agrawal@ti.com>
>>>>> ---
>>>>>  .../packagegroup-arago-tisdk-hmi-sdk-host.bb       | 26 +++++++++++++++++++++
>>>>>  .../packagegroups/packagegroup-arago-tisdk-hmi.bb  | 27 ++++++++++++++++++++++
>>>>>  2 files changed, 53 insertions(+)
>>>>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>>>>  create mode 100755 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>>>>
>>>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>>>> new file mode 100755
>>>>> index 0000000..d58536c
>>>>> --- /dev/null
>>>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi-sdk-host.bb
>>>>> @@ -0,0 +1,26 @@
>>>>> +DESCRIPTION = "Task to add HMI related sources into the SDK"
>>>> SUMMARY is missing.
>> I see either SUMMARY or DESCRIPTION in other packagefroup files. Do you
>> want me to rename the DESCRIPTION as SUMMARY or you want to see more
>> information as part of SUMMARY. If yes, what additional information
>> should I add there.
> Please see my comment for patch #1 with the link.
>
>

Sorry missed seeing that earlier. I am keeping SUMMARY and removing
DESCRIPTION as DESCRIPTION defaults to SUMMARY and nothing much to
describe there.


>>>>> +LICENSE = "BSD-3-Clause"
>>>> By default all OE metadata is licensed under MIT. Unless you have a very 
>>>> specific need to license packagegroup under BSD, I'd suggest leaving it as is. 
>>>> BTW since MIT is default, LICENSE can be omitted when inheriting packagegroup.
>> This was suggested by Vivek. His comment was "Any user-space demo
>> applications that we develop should be in TI BSD-3-clause license, as
>> that's the most friendliest and can be used by others (RTOS, VxWorks,
>> etc.)."
> A packagegroup is not a user-space demo application, hence my comment above.
>

Got it. Thanks.


>>>>> +PR = "r1"
>>>> Not critical, but PR can also be omitted for new recipes.
>> I am keeping it for now else in future I will forget to add the
>> revision. If I keep it, would you suggest it to be "r0" or "r1".
> Doesn't matter, but it defaults to "r0".
>
>
>>>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>>> +
>>>>> +inherit packagegroup
>>>>> +
>>>>> +HMI = ""
>>>>> +
>>>>> +HMI_append_ti43x = " \
>>>>> +    evse-hmi-src \
>>>>> +"
>>>>> +
>>>>> +HMI_append_ti33x = " \
>>>>> +    evse-hmi-src \
>>>>> +"
>>>>> +
>>>>> +
>>>>> +HMI_append_omap-a15 = " \
>>>>> +    evse-hmi-src \
>>>>> +"
>>>>> +
>>>>> +RDEPENDS_${PN} = "\
>>>>> +    ${HMI} \
>>>>> +"
>>>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>>>> new file mode 100755
>>>>> index 0000000..9066c72
>>>>> --- /dev/null
>>>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-hmi.bb
>>>>> @@ -0,0 +1,27 @@
>>>> Same comments here.
>>>>
>>>>
>>>>> +DESCRIPTION = "Task to add HMI related packages"
>>>>> +LICENSE = "BSD-3-Clause"
>>>>> +PR = "r1"
>>>>> +
>>>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>>> +
>>>>> +inherit packagegroup
>>>>> +
>>>>> +HMI = " \
>>>>> +"
>>>>> +
>>>>> +
>>>>> +HMI_append_ti33x = " \
>>>>> +    evse-hmi \
>>>>> +"
>>>>> +
>>>>> +HMI_append_ti43x = " \
>>>>> +    evse-hmi \
>>>>> +"
>>>>> +
>>>>> +HMI_append_omap-a15 = " \
>>>>> +    evse-hmi \
>>>>> +"
>>>>> +
>>>>> +
>>>>> +RDEPENDS_${PN} = "\
>>>>> +"
>>> Also, you seem to be missing to add anything in RDEPENDS...
>>>
>>>
>>>>> -- 
>>>>> 2.13.0
>>>>>
>>>> _______________________________________________
>>>> meta-arago mailing list
>>>> meta-arago@arago-project.org
>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago



^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-08-29 21:17 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 16:38 [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Manisha Agrawal
2017-08-29 16:38 ` [morty][PATCH v2 2/6] matrix : add new EVSE HMI demo Manisha Agrawal
2017-08-29 17:26   ` Denys Dmytriyenko
2017-08-29 16:38 ` [morty][PATCH v2 3/6] meta-arago-extras : matrix : recipe for evse hmi Manisha Agrawal
2017-08-29 17:20   ` Denys Dmytriyenko
2017-08-29 16:38 ` [morty][PATCH v2 4/6] recipes-core : packagegroups: hmi Manisha Agrawal
2017-08-29 17:16   ` Denys Dmytriyenko
2017-08-29 19:55     ` Denys Dmytriyenko
2017-08-29 20:56       ` Manisha Agrawal
2017-08-29 21:05         ` Denys Dmytriyenko
2017-08-29 21:17           ` Manisha Agrawal
2017-08-29 16:38 ` [morty][PATCH v2 5/6] meta-arago-distro: conf : arago-source-ipk.inc Manisha Agrawal
2017-08-29 17:32   ` Denys Dmytriyenko
2017-08-29 16:38 ` [morty][PATCH v2 6/6] arago-distro : recipes-core : tisdk-rootfs-image Manisha Agrawal
2017-08-29 17:29   ` Denys Dmytriyenko
2017-08-29 17:11 ` [morty][PATCH v2 1/6] meta-arago-extras : recipe-apps : evse-hmi : new demo Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.