From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, victork@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume regression (since 2.9)
Date: Tue, 29 Aug 2017 18:02:53 +0300 [thread overview]
Message-ID: <20170829180219-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170829144805.28872-3-marcandre.lureau@redhat.com>
On Tue, Aug 29, 2017 at 04:48:05PM +0200, Marc-André Lureau wrote:
> Commit e10e798c85c2331 switched to libvhost-user which lacked support
> for resuming the avail_idx based on used_idx.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1485867
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Can we add a test for reconnect to catch the regression?
> ---
> tests/vhost-user-bridge.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
> index 1e5b5ca3da..dca48512ba 100644
> --- a/tests/vhost-user-bridge.c
> +++ b/tests/vhost-user-bridge.c
> @@ -466,11 +466,18 @@ vubr_panic(VuDev *dev, const char *msg)
> vubr->quit = 1;
> }
>
> +static bool
> +vubr_queue_resume_to_used(VuDev *dev, int qidx)
> +{
> + return true;
> +}
> +
> static const VuDevIface vuiface = {
> .get_features = vubr_get_features,
> .set_features = vubr_set_features,
> .process_msg = vubr_process_msg,
> .queue_set_started = vubr_queue_set_started,
> + .queue_resume_to_used = vubr_queue_resume_to_used,
> };
>
> static void
> --
> 2.14.1.146.gd35faa819
next prev parent reply other threads:[~2017-08-29 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 14:48 [Qemu-devel] [PATCH 0/2] vhost-user-bridge reconnect regression Marc-André Lureau
2017-08-29 14:48 ` [Qemu-devel] [PATCH 1/2] libvhost-user: support resuming vq->last_avail_idx based on used_idx Marc-André Lureau
2017-08-29 15:01 ` Michael S. Tsirkin
2017-08-29 15:04 ` Marc-André Lureau
2017-08-29 15:09 ` Michael S. Tsirkin
2017-08-29 15:18 ` Marc-André Lureau
2017-08-29 15:20 ` Michael S. Tsirkin
2017-08-29 14:48 ` [Qemu-devel] [PATCH 2/2] vhost-user-bridge: fix resume regression (since 2.9) Marc-André Lureau
2017-08-29 15:02 ` Michael S. Tsirkin [this message]
2017-08-29 15:22 ` Marc-André Lureau
2017-08-29 15:27 ` Michael S. Tsirkin
2017-08-29 15:02 ` [Qemu-devel] [PATCH 0/2] vhost-user-bridge reconnect regression Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829180219-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victork@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.