All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Florian Eckert <fe@dev.tdt.de>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org, dev@kresin.me
Subject: Re: [v2,2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
Date: Tue, 29 Aug 2017 18:00:51 -0700	[thread overview]
Message-ID: <20170830010051.GA15869@roeck-us.net> (raw)
In-Reply-To: <20170821124123.17470-2-fe@dev.tdt.de>

On Mon, Aug 21, 2017 at 02:41:23PM +0200, Florian Eckert wrote:
> Document the devicetree bindings for the ltq-cputemp
> 
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>

When you resend, please copy DT maintainers.

> ---
>  Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> new file mode 100644
> index 000000000000..991b05cbcb4a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt
> @@ -0,0 +1,10 @@
> +Lantiq cpu temperatur sensor driver

Nitpick: s/driver//

The file describes the sensor, not the driver.

> +
> +Requires node properties:

Required

> +- "compatible" value :

Just "- compatible:" (without the '"')

> +	"lantiq,cputemp"
> +
> +Example:
> +	cputemp@0 {
> +		compatible = "lantiq,cputemp";
> +	};

  reply	other threads:[~2017-08-30  1:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 12:41 [PATCH v2 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
2017-08-21 12:41 ` [PATCH v2 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
2017-08-30  1:00   ` Guenter Roeck [this message]
2017-08-30  0:58 ` [v2,1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830010051.GA15869@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=dev@kresin.me \
    --cc=fe@dev.tdt.de \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.