All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC
Date: Wed, 30 Aug 2017 11:06:15 +0300	[thread overview]
Message-ID: <20170830080615.GB6378@ahiler-desk1.ger.corp.intel.com> (raw)
In-Reply-To: <1504003758.12240.16.camel@intel.com>

On Tue, Aug 29, 2017 at 01:49:18PM +0300, Mika Kahola wrote:
> In my view, this is a valid check.
> 
> Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> 
> On Tue, 2017-08-29 at 13:32 +0300, Marta Lofstedt wrote:
> > Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para
> > ms.
> > This leads to segfault on machines where the subtest should be
> > skipped.
> > 
> > Signed-off-by: Marta Lofstedt <marta.lofstedt@intel.com>

pushed

thanks for the patch and the review :-)

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-08-30  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 10:32 [PATCH i-g-t] tests/kms_atomic: subtest atomic_invalid_params requires CRTC Marta Lofstedt
2017-08-29 10:49 ` Mika Kahola
2017-08-30  8:06   ` Arkadiusz Hiler [this message]
2017-08-29 11:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-29 12:25 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830080615.GB6378@ahiler-desk1.ger.corp.intel.com \
    --to=arkadiusz.hiler@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.