From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn02G-0001ea-LI for qemu-devel@nongnu.org; Wed, 30 Aug 2017 06:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn02C-0000Lj-Ll for qemu-devel@nongnu.org; Wed, 30 Aug 2017 06:15:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56018) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dn02C-0000KT-BR for qemu-devel@nongnu.org; Wed, 30 Aug 2017 06:15:44 -0400 Date: Wed, 30 Aug 2017 11:15:36 +0100 From: "Daniel P. Berrange" Message-ID: <20170830101536.GC18526@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170824192315.5897-1-ehabkost@redhat.com> <20170824192315.5897-4-ehabkost@redhat.com> <20170829111345.GI3783@redhat.com> <20170829131258.GA30734@localhost.localdomain> <20170829213657.GO27715@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170829213657.GO27715@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH] fixup! hostmem-file: Add "discard-data" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Zack Cornelius , qemu-devel@nongnu.org, Igor Mammedov , "Dr. David Alan Gilbert" On Tue, Aug 29, 2017 at 06:36:57PM -0300, Eduardo Habkost wrote: > On Tue, Aug 29, 2017 at 10:12:58AM -0300, Eduardo Habkost wrote: > > On Tue, Aug 29, 2017 at 12:13:45PM +0100, Daniel P. Berrange wrote: > > > On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote: > [...] > > > > @@ -4172,6 +4172,9 @@ the path to either a shared memory or huge page filesystem mount. > > > > The @option{share} boolean option determines whether the memory > > > > region is marked as private to QEMU, or shared. The latter allows > > > > a co-operating external process to access the QEMU memory region. > > > > +Setting the @option{discard-data} boolean option to @var{on} > > > > +indicates that file contents can be destroyed when QEMU exits, > > > > +to avoid unnecessarily flushing data to the backing file. > > > > > > We should note that this only works if QEMU shuts down normally. If QEMU > > > is aggressively killed (SIGKILL) or aborts for some reason, then we'll > > > never get a chance to invoke madvise(), so presumably the kernel will > > > still flush the data > > > > Good point. I tried to not give any guarantees by saying > > "contents _can_ be destroyed", but users may still have different > > expectations. > > > > I will change it to: > > > > Setting the @option{discard-data} boolean option to @var{on} > > indicates that file contents can be destroyed when QEMU exits, > > to avoid unnecessarily flushing data to the backing file. Note > > that @option{discard-data} is only an optimization, and QEMU > > might not discard file contents if it aborts unexpectedly or is > > terminated using SIGKILL. > > Fixup patch: > > Signed-off-by: Eduardo Habkost > --- > qemu-options.hx | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index ad985e4..de9a18a 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -4174,7 +4174,10 @@ region is marked as private to QEMU, or shared. The latter allows > a co-operating external process to access the QEMU memory region. > Setting the @option{discard-data} boolean option to @var{on} > indicates that file contents can be destroyed when QEMU exits, > -to avoid unnecessarily flushing data to the backing file. > +to avoid unnecessarily flushing data to the backing file. Note > +that @option{discard-data} is only an optimization, and QEMU > +might not discard file contents if it aborts unexpectedly or is > +terminated using SIGKILL. > > @item -object rng-random,id=@var{id},filename=@var{/dev/random} For the combined patch: Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|