From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn3DI-0004PC-IB for qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn3DF-0004YM-B0 for qemu-devel@nongnu.org; Wed, 30 Aug 2017 09:39:24 -0400 Date: Wed, 30 Aug 2017 14:39:17 +0100 From: Stefan Hajnoczi Message-ID: <20170830133917.GQ24565@stefanha-x1.localdomain> References: <20170822131832.20191-1-pbonzini@redhat.com> <20170822131832.20191-4-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822131832.20191-4-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 03/10] scsi: introduce scsi_build_sense List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, famz@redhat.com, qemu-block@nongnu.org On Tue, Aug 22, 2017 at 03:18:25PM +0200, Paolo Bonzini wrote: > Move more knowledge of sense data format out of hw/scsi/scsi-bus.c > for reusability. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/scsi-bus.c | 8 +------- > include/scsi/utils.h | 2 ++ > scsi/utils.c | 11 +++++++++++ > 3 files changed, 14 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi