From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751557AbdH3PM1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Aug 2017 11:12:27 -0400
Received: from heliosphere.sirena.org.uk ([172.104.155.198]:55278 "EHLO
        heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751317AbdH3PM0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Aug 2017 11:12:26 -0400
Date: Wed, 30 Aug 2017 16:12:24 +0100
From: Mark Brown <broonie@kernel.org>
To: Eric Jeong <eric.jeong.opensource@diasemi.com>
Cc: LINUXKERNEL <linux-kernel@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH V1] regulator: pv88090: Exception handling for out of
 bounds
Message-ID: <20170830151223.nue35m3tdu3hfse3@sirena.org.uk>
References: <20170830090719.4DA4A5F7E7@krsrvapps-01.diasemi.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="rg5eoaoohhbxj4hu"
Content-Disposition: inline
In-Reply-To: <20170830090719.4DA4A5F7E7@krsrvapps-01.diasemi.com>
X-Cookie: There Is No Cabal.
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--rg5eoaoohhbxj4hu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 30, 2017 at 05:54:27PM +0900, Eric Jeong wrote:

I've applied this but a few things to bear in mind for future
submissions:

> From: Eric Jeong <eric.jeong.opensource@diasemi.com>

Please try to ensure that your e-mail address matches the one you use
for signoff, this avoids your mail looking like a non-author send that's
missing a signoff.

> This is a patch for exception handlding that the index of array is
> out of bounds. And the definitions have been updated to use
> proper device name.

This'd be easier to review with the rename separated out from the
functional change.

> @@ -43,7 +43,7 @@ enum {
>  struct pv88090_regulator {
>  	struct regulator_desc desc;
>  	/* Current limiting */
> -	unsigned	n_current_limits;
> +	unsigned int n_current_limits;

This is fine but it's an unrelated stylistic change.

--rg5eoaoohhbxj4hu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmm1dcACgkQJNaLcl1U
h9DuSgf+J7fNrLwlRynKRQ8ZyEduO3YdixFfz+wz2BAZC1OZuMyMLsqtpVC/Oihr
1Svrxq3/dWhF0MyJRiJujx38GzqafqNrhF1/WpGQnbHtkQDaEwjBF5QSZpZOp6la
w/1GZ/Qz2jkh7wIaP3YWCGB3BP64wQ2ha6AUgy12cxAhP7YdMTxW1WtiYMAYL/Yg
+xDTz60g4TfGnaPe1wU20nbX4SQlMPGc6rdovfUFAxR9G8K0xaaU+sbO21AXGxOv
Wb1HFVv93cg4+KXFAiwNZAayPMOd/J227MTw1fZ4eqa8eyUzkUlFfQkSh5sMOC7N
BtiRxqbEkB7zcprq/xP4D6QFqp/cZg==
=2Db1
-----END PGP SIGNATURE-----

--rg5eoaoohhbxj4hu--