From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Dave Chinner <david@fromorbit.com>,
Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] ext4: introduce per-inode DAX flag
Date: Wed, 30 Aug 2017 17:29:31 +0200 [thread overview]
Message-ID: <20170830152931.GE5920@quack2.suse.cz> (raw)
In-Reply-To: <20170830123450.GA14976@infradead.org>
On Wed 30-08-17 05:34:50, Christoph Hellwig wrote:
> On Wed, Aug 30, 2017 at 12:00:59PM +0200, Jan Kara wrote:
> > /dev/ram0 /mnt xfs rw,relatime,attr2,dax,inode64,noquota 0 0
> >
> > marvin5:~/:[0]# ls /mnt/
> > fsxfile fsxfile.fsxgood fsxfile.fsxlog
> >
> > marvin5:~/:[0]# ./xfsprogs-dev/io/xfs_io -c 'lsattr' /mnt/fsxfile
> > -p-------------- /mnt/fsxfile
> >
> > marvin5:~/:[0]# ./xfsprogs-dev/io/xfs_io -c 'chattr +x' /mnt/fsxfile
> >
> > marvin5:~/:[0]# ./xfsprogs-dev/io/xfs_io -c 'lsattr' /mnt/fsxfile
> > -p-------------- /mnt/fsxfile
> >
> > No DAX flag set and no error... What am I doing wrong?
>
> Odd. Even on a non-DAX device the flag sticks for me:
>
> root@testvm:~# mount /dev/sda /mnt/
> root@testvm:~# touch foo
> root@testvm:~# cd /mnt/
> root@testvm:/mnt# xfs_io -c 'chattr +x' foo
> root@testvm:/mnt# xfs_io -c 'lsattr' foo
> --------------x- foo
OK, tracked this down. I had the XFS filesystem created so that
ip->i_d.di_version < 3 check in xfs_set_diflags() was true and so the flag
got silently ignored. I'd hope to get error in such case but whatever...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-08-30 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 16:09 [PATCH] ext4: introduce per-inode DAX flag Lukas Czerner
2017-08-05 8:46 ` Christoph Hellwig
2017-08-07 12:12 ` Lukas Czerner
2017-08-08 9:00 ` Lukas Czerner
2017-08-11 10:01 ` Christoph Hellwig
2017-08-11 12:11 ` Lukas Czerner
2017-08-11 12:58 ` Christoph Hellwig
2017-08-11 13:41 ` Lukas Czerner
2017-08-24 18:20 ` Theodore Ts'o
2017-08-25 7:54 ` Christoph Hellwig
2017-08-25 15:14 ` Theodore Ts'o
2017-08-25 15:40 ` Christoph Hellwig
2017-08-25 16:28 ` Theodore Ts'o
2017-08-25 23:33 ` Dave Chinner
2017-08-28 7:38 ` Christoph Hellwig
2017-08-28 10:10 ` Dave Chinner
2017-08-29 15:49 ` Jan Kara
2017-08-29 22:57 ` Dave Chinner
2017-08-30 10:00 ` Jan Kara
2017-08-30 12:34 ` Christoph Hellwig
2017-08-30 15:00 ` Theodore Ts'o
2017-08-30 15:30 ` Lukas Czerner
2017-08-30 15:29 ` Jan Kara [this message]
2017-08-30 16:05 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830152931.GE5920@quack2.suse.cz \
--to=jack@suse.cz \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.