From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751562AbdH3Plb (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Aug 2017 11:41:31 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:44854 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751358AbdH3Pla (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Aug 2017 11:41:30 -0400
Date: Wed, 30 Aug 2017 16:41:28 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: arve@android.com, riandrews@android.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read
Message-ID: <20170830154128.GP5426@ZenIV.linux.org.uk>
References: <20170830150007.3953-1-hch@lst.de>
 <20170830150007.3953-9-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170830150007.3953-9-hch@lst.de>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 30, 2017 at 04:59:59PM +0200, Christoph Hellwig wrote:
> -		fpos = vma->vm_pgoff;
> -		fpos <<= PAGE_SHIFT;

> +		loff_t fpos = vma->vm_pgoff << PAGE_SHIFT;

Umm...  Are you sure it's OK on 32bit hosts?