From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy
Date: Wed, 30 Aug 2017 22:29:46 +0200 [thread overview]
Message-ID: <20170830222946.5ad6f28b@windsurf.lan> (raw)
In-Reply-To: <c21debe1fe36162b182803d45b5e6b0ab4ff575d.1503898456.git.baruch@tkos.co.il>
Hello,
On Mon, 28 Aug 2017 08:34:15 +0300, Baruch Siach wrote:
> The only plugin that uses libusb/libusb-compat is the ftdi plugin. This
> plugin needs libftdi1 that already depends on libusb in Buildroot. So in
> practice libusb-compat is never actually used; we can safely remove it.
> The libusb dependency is implicit in the libftdi1 optional dependency.
Are you sure ?
From the configure.ac script:
AC_CHECK_HEADERS([usb.h libusb-1.0/libusb.h libusb.h])
AC_CHECK_LIB([usb],[usb_get_string],[usb_libs="-lusb"],,)
AM_CONDITIONAL([BUILD_USB],[test x$usb_libs != x])
AC_CHECK_LIB([usb-1.0],[libusb_lock_events],[usb_libs="$usb_libs -lusb-1.0"],,)
In addition, I do see a number of plugins linked with libusb-0.1:
$ readelf -d output/target/usr/lib/lirc/plugins/* | grep libusb-0.1
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
0x00000001 (NEEDED) Shared library: [libusb-0.1.so.4]
Am I missing something ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-30 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 5:34 [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Baruch Siach
2017-08-28 5:34 ` [Buildroot] [PATCH next 2/2] libftdi1: bump to version 1.4 Baruch Siach
2017-08-30 20:30 ` Thomas Petazzoni
2017-08-30 20:29 ` Thomas Petazzoni [this message]
2017-08-31 4:18 ` [Buildroot] [PATCH next 1/2] lirc-tools: remove useless libusb-compat dependnecy Baruch Siach
2017-08-31 7:01 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830222946.5ad6f28b@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.