From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbdHaIKi (ORCPT ); Thu, 31 Aug 2017 04:10:38 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:40279 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbdHaIKd (ORCPT ); Thu, 31 Aug 2017 04:10:33 -0400 Date: Thu, 31 Aug 2017 10:10:21 +0200 From: Alexandre Belloni To: Christophe JAILLET Cc: perex@perex.cz, tiwai@suse.com, arvind.yadav.cs@gmail.com, nicolas.ferre@microchip.com, broonie@kernel.org, garsilva@embeddedor.com, andriy.shevchenko@linux.intel.com, bhumirks@gmail.com, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Message-ID: <20170831081021.g4luo557ggtnyfyg@piout.net> References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote: > If 'clk_prepare_enable()' fails, we must release some resources before > returning. Add a new label in the existing error handling path and 'goto' > there. > > Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of clk_prepare_enable.") > Signed-off-by: Christophe JAILLET And here is the fallout of the stupid, brainless "fixing" of issues reported by static analysis tools. This clk_prepare_enable will never fail. If it was going to fail, the platform would never boot to a point were it is able to execute that code. It is really annoying to have so much churn for absolutely 0 benefit. Anyway, Acked-by: Alexandre Belloni > --- > sound/atmel/ac97c.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index 30c64ab210d9..5ffefac2fa8f 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -785,7 +785,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > } > retval = clk_prepare_enable(pclk); > if (retval) > - return retval; > + goto err_prepare_enable; > > retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, > SNDRV_DEFAULT_STR1, THIS_MODULE, > @@ -881,6 +881,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > snd_card_free(card); > err_snd_card_new: > clk_disable_unprepare(pclk); > +err_prepare_enable: > clk_put(pclk); > return retval; > } > -- > 2.11.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Thu, 31 Aug 2017 08:10:21 +0000 Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Message-Id: <20170831081021.g4luo557ggtnyfyg@piout.net> List-Id: References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: alsa-devel@alsa-project.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com, tiwai@suse.com, broonie@kernel.org, garsilva@embeddedor.com, arvind.yadav.cs@gmail.com, bhumirks@gmail.com On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote: > If 'clk_prepare_enable()' fails, we must release some resources before > returning. Add a new label in the existing error handling path and 'goto' > there. > > Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of clk_prepare_enable.") > Signed-off-by: Christophe JAILLET And here is the fallout of the stupid, brainless "fixing" of issues reported by static analysis tools. This clk_prepare_enable will never fail. If it was going to fail, the platform would never boot to a point were it is able to execute that code. It is really annoying to have so much churn for absolutely 0 benefit. Anyway, Acked-by: Alexandre Belloni > --- > sound/atmel/ac97c.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index 30c64ab210d9..5ffefac2fa8f 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -785,7 +785,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > } > retval = clk_prepare_enable(pclk); > if (retval) > - return retval; > + goto err_prepare_enable; > > retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, > SNDRV_DEFAULT_STR1, THIS_MODULE, > @@ -881,6 +881,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > snd_card_free(card); > err_snd_card_new: > clk_disable_unprepare(pclk); > +err_prepare_enable: > clk_put(pclk); > return retval; > } > -- > 2.11.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Date: Thu, 31 Aug 2017 10:10:21 +0200 Message-ID: <20170831081021.g4luo557ggtnyfyg@piout.net> References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by alsa0.perex.cz (Postfix) with ESMTP id E70B1267256 for ; Thu, 31 Aug 2017 10:10:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Christophe JAILLET Cc: alsa-devel@alsa-project.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com, tiwai@suse.com, broonie@kernel.org, garsilva@embeddedor.com, arvind.yadav.cs@gmail.com, bhumirks@gmail.com List-Id: alsa-devel@alsa-project.org On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote: > If 'clk_prepare_enable()' fails, we must release some resources before > returning. Add a new label in the existing error handling path and 'goto' > there. > > Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of clk_prepare_enable.") > Signed-off-by: Christophe JAILLET And here is the fallout of the stupid, brainless "fixing" of issues reported by static analysis tools. This clk_prepare_enable will never fail. If it was going to fail, the platform would never boot to a point were it is able to execute that code. It is really annoying to have so much churn for absolutely 0 benefit. Anyway, Acked-by: Alexandre Belloni > --- > sound/atmel/ac97c.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index 30c64ab210d9..5ffefac2fa8f 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -785,7 +785,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > } > retval = clk_prepare_enable(pclk); > if (retval) > - return retval; > + goto err_prepare_enable; > > retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, > SNDRV_DEFAULT_STR1, THIS_MODULE, > @@ -881,6 +881,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > snd_card_free(card); > err_snd_card_new: > clk_disable_unprepare(pclk); > +err_prepare_enable: > clk_put(pclk); > return retval; > } > -- > 2.11.0 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com