From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Thu, 31 Aug 2017 11:03:14 +0200 Subject: [PATCH 5/5] arm: dts: sun8i: Add the TBS A711 tablet devicetree In-Reply-To: References: <20170825092617.32533-1-maxime.ripard@free-electrons.com> <20170825092617.32533-5-maxime.ripard@free-electrons.com> Message-ID: <20170831090314.ubfn3csgp5svtlih@flea.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Thu, Aug 31, 2017 at 02:52:43PM +0800, Chen-Yu Tsai wrote: > > + non-removable; > > + wakeup-source; > > + status = "okay"; > > + > > + brcmf: wifi at 1 { > > + reg = <1>; > > + compatible = "brcm,bcm4329-fmac"; > > + interrupt-parent = <&r_pio>; > > + interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 WL_WAKE_UP */ > > + interrupt-names = "host-wake"; > > + }; > > +}; > > + > > +&mmc2 { > > + pinctrl-0 = <&mmc2_8bit_emmc_pins>; > > + pinctrl-names = "default"; > > + vmmc-supply = <®_vcc3v3>; > > emmc has separate vddq lines. vqmmc-supply should be provided even though it > may be the same as vmmc-supply. The two refer to different things at the board > level. My understanding was that vqmmc wasn't needed if it was the same regulator than vmmc. > > +/* There's the BT part of the AP6210 connected to that UART */ > > +&uart1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart1_pg_pins &uart1_rtscts_pins>; > > Splitting it as separate phandles ( <&...> ) would make it more readable. > Also the rx/tx pingroup name should be changed Ack. > > > + status = "okay"; > > +}; > > + > > +&usbphy { > > No VBUS? Argh, I forgot them. I'll add them, obviously. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: