From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdHaKip (ORCPT ); Thu, 31 Aug 2017 06:38:45 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:35300 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdHaKio (ORCPT ); Thu, 31 Aug 2017 06:38:44 -0400 Date: Thu, 31 Aug 2017 11:38:25 +0100 From: Mark Brown To: Takashi Iwai Cc: Alexandre Belloni , alsa-devel@alsa-project.org, garsilva@embeddedor.com, arvind.yadav.cs@gmail.com, bhumirks@gmail.com, andriy.shevchenko@linux.intel.com, nicolas.ferre@microchip.com, perex@perex.cz, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe JAILLET Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Message-ID: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> <20170831081021.g4luo557ggtnyfyg@piout.net> <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sj65f6ptnm2w3c2q" Content-Disposition: inline In-Reply-To: X-Cookie: Real programs don't eat cache. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sj65f6ptnm2w3c2q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote: > This is again a typical problem by such a trivial fix patch: the code > looks as if it were trivial and correct, buried in a patch series that > easily leads to the oversight by the maintainer's review. Right, plus the amount of context that diff shows you. --sj65f6ptnm2w3c2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmn5yAACgkQJNaLcl1U h9DpcQf+NRJiJpVSJaKTc1vePwbgOCafygwxhOHTrnSlNLRQjxakDkUcdvw8htuf TgR4iBV59vMh8y91FBnV36NMqYKgJmX3PZy46S18Szm6jUYoV2INaiQJUeddmWNa KUq4EqZEvf0XjnV/c5f2geN+JPOM36mYh/Ndkp5v98opU2/UTQ/rHtGJeHdjHgYQ rGFJweRJlAaofY5oQXkvzOyaF2z06bheBq4hpL5aQFhNUSopbqv1dEHzVjxC+ZNL gov/C6udBftxCxRS+tLAknx3txBTn077OTGEQb4xp+Bh82Lap9DNFLTaS3dqcLGG 5NA+DtMlKTH5oIReI0cp2x4msP10CQ== =l4TI -----END PGP SIGNATURE----- --sj65f6ptnm2w3c2q-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Thu, 31 Aug 2017 10:38:25 +0000 Subject: Re: [alsa-devel] [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Message-Id: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="sj65f6ptnm2w3c2q" List-Id: References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> <20170831081021.g4luo557ggtnyfyg@piout.net> <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> In-Reply-To: To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com, garsilva@embeddedor.com, Christophe JAILLET , arvind.yadav.cs@gmail.com, Alexandre Belloni , andriy.shevchenko@linux.intel.com, bhumirks@gmail.com --sj65f6ptnm2w3c2q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote: > This is again a typical problem by such a trivial fix patch: the code > looks as if it were trivial and correct, buried in a patch series that > easily leads to the oversight by the maintainer's review. Right, plus the amount of context that diff shows you. --sj65f6ptnm2w3c2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmn5yAACgkQJNaLcl1U h9DpcQf+NRJiJpVSJaKTc1vePwbgOCafygwxhOHTrnSlNLRQjxakDkUcdvw8htuf TgR4iBV59vMh8y91FBnV36NMqYKgJmX3PZy46S18Szm6jUYoV2INaiQJUeddmWNa KUq4EqZEvf0XjnV/c5f2geN+JPOM36mYh/Ndkp5v98opU2/UTQ/rHtGJeHdjHgYQ rGFJweRJlAaofY5oQXkvzOyaF2z06bheBq4hpL5aQFhNUSopbqv1dEHzVjxC+ZNL gov/C6udBftxCxRS+tLAknx3txBTn077OTGEQb4xp+Bh82Lap9DNFLTaS3dqcLGG 5NA+DtMlKTH5oIReI0cp2x4msP10CQ== =l4TI -----END PGP SIGNATURE----- --sj65f6ptnm2w3c2q-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ALSA: ac97c: Fix an error handling path in 'atmel_ac97c_probe()' Date: Thu, 31 Aug 2017 11:38:25 +0100 Message-ID: <20170831103825.77shnqzi7ykpm7ah@sirena.org.uk> References: <20170831044042.23306-1-christophe.jaillet@wanadoo.fr> <20170831081021.g4luo557ggtnyfyg@piout.net> <20170831101903.avhj5tqywpvfsj4u@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4202349949894885874==" Return-path: Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 75BB1267217 for ; Thu, 31 Aug 2017 12:38:26 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, nicolas.ferre@microchip.com, garsilva@embeddedor.com, Christophe JAILLET , arvind.yadav.cs@gmail.com, Alexandre Belloni , andriy.shevchenko@linux.intel.com, bhumirks@gmail.com List-Id: alsa-devel@alsa-project.org --===============4202349949894885874== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sj65f6ptnm2w3c2q" Content-Disposition: inline --sj65f6ptnm2w3c2q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote: > This is again a typical problem by such a trivial fix patch: the code > looks as if it were trivial and correct, buried in a patch series that > easily leads to the oversight by the maintainer's review. Right, plus the amount of context that diff shows you. --sj65f6ptnm2w3c2q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmn5yAACgkQJNaLcl1U h9DpcQf+NRJiJpVSJaKTc1vePwbgOCafygwxhOHTrnSlNLRQjxakDkUcdvw8htuf TgR4iBV59vMh8y91FBnV36NMqYKgJmX3PZy46S18Szm6jUYoV2INaiQJUeddmWNa KUq4EqZEvf0XjnV/c5f2geN+JPOM36mYh/Ndkp5v98opU2/UTQ/rHtGJeHdjHgYQ rGFJweRJlAaofY5oQXkvzOyaF2z06bheBq4hpL5aQFhNUSopbqv1dEHzVjxC+ZNL gov/C6udBftxCxRS+tLAknx3txBTn077OTGEQb4xp+Bh82Lap9DNFLTaS3dqcLGG 5NA+DtMlKTH5oIReI0cp2x4msP10CQ== =l4TI -----END PGP SIGNATURE----- --sj65f6ptnm2w3c2q-- --===============4202349949894885874== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4202349949894885874==--