From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org, yliu@fridaylinux.org, maxime.coquelin@redhat.com
Cc: stephen@networkplumber.org, stable@dpdk.org
Subject: [PATCH 9/9] net/virtio: fix Rx handler when checksum is requested
Date: Thu, 31 Aug 2017 15:40:15 +0200 [thread overview]
Message-ID: <20170831134015.1383-10-olivier.matz@6wind.com> (raw)
In-Reply-To: <20170831134015.1383-1-olivier.matz@6wind.com>
The simple Rx handler is selected even if Rx checksum offload is
requested by the application, but this handler does not support
offloads. This results in broken received packets (no checksum flag but
invalid checksum in the mbuf data).
Disable the simple Rx handler in that case.
Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload")
Cc: stable@dpdk.org
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/virtio/virtio_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 4845d44b0..0e616bcf0 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1760,6 +1760,9 @@ virtio_dev_configure(struct rte_eth_dev *dev)
hw->use_simple_tx = 0;
}
+ if (rxmode->hw_ip_checksum)
+ hw->use_simple_rx = 0;
+
return 0;
}
--
2.11.0
next prev parent reply other threads:[~2017-08-31 13:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 13:40 [PATCH 0/9] virtio fixes Olivier Matz
2017-08-31 13:40 ` [PATCH 1/9] net/virtio: revert "do not claim to support LRO" Olivier Matz
2017-08-31 13:40 ` [PATCH 2/9] net/virtio: revert "do not falsely claim to do IP checksum" Olivier Matz
2017-08-31 13:47 ` Olivier MATZ
2017-08-31 13:40 ` [PATCH 3/9] doc: fix description of L4 Rx checksum offload Olivier Matz
2017-08-31 13:40 ` [PATCH 4/9] net/virtio: fix log levels in configure Olivier Matz
2017-08-31 13:40 ` [PATCH 5/9] net/virtio: fix mbuf port for simple Rx function Olivier Matz
2017-08-31 13:48 ` Olivier MATZ
2017-08-31 13:40 ` [PATCH 6/9] net/virtio: fix queue setup consistency Olivier Matz
2017-08-31 13:49 ` Olivier MATZ
2017-08-31 13:40 ` [PATCH 7/9] net/virtio: rationalize setting of Rx/Tx handlers Olivier Matz
2017-09-01 9:19 ` Yuanhan Liu
2017-09-01 9:52 ` Olivier MATZ
2017-09-01 12:31 ` Yuanhan Liu
2017-09-06 14:40 ` Olivier MATZ
2017-09-07 8:13 ` Yuanhan Liu
2017-08-31 13:40 ` [PATCH 8/9] net/virtio: keep Rx handler whatever the Tx queue config Olivier Matz
2017-08-31 13:50 ` Olivier MATZ
2017-09-01 9:25 ` Yuanhan Liu
2017-09-01 9:58 ` Olivier MATZ
2017-09-01 12:22 ` Yuanhan Liu
2017-08-31 13:40 ` Olivier Matz [this message]
2017-08-31 13:51 ` [PATCH 9/9] net/virtio: fix Rx handler when checksum is requested Olivier MATZ
2017-09-07 12:13 ` [PATCH v2 00/10] virtio fixes Olivier Matz
2017-09-07 12:13 ` [PATCH v2 01/10] net/virtio: revert "do not claim to support LRO" Olivier Matz
2017-09-07 12:13 ` [PATCH v2 02/10] net/virtio: revert "do not falsely claim to do IP checksum" Olivier Matz
2017-09-07 12:13 ` [PATCH v2 03/10] doc: fix description of L4 Rx checksum offload Olivier Matz
2017-09-07 12:13 ` [PATCH v2 04/10] net/virtio: fix log levels in configure Olivier Matz
2017-09-07 12:13 ` [PATCH v2 05/10] net/virtio: fix mbuf port for simple Rx function Olivier Matz
2017-09-07 12:13 ` [PATCH v2 06/10] net/virtio: fix queue setup consistency Olivier Matz
2017-12-06 5:25 ` Tiwei Bie
2017-12-07 14:14 ` Olivier MATZ
2017-12-08 2:17 ` Tiwei Bie
2018-02-01 3:14 ` Yao, Lei A
2018-02-01 8:27 ` Olivier Matz
2018-02-07 8:31 ` Xu, Qian Q
2018-02-07 22:01 ` Olivier Matz
2018-02-09 5:44 ` Wang, Zhihong
2018-02-09 8:59 ` Maxime Coquelin
2018-02-09 9:40 ` Maxime Coquelin
2017-09-07 12:13 ` [PATCH v2 07/10] net/virtio: rationalize setting of Rx/Tx handlers Olivier Matz
2017-09-07 12:13 ` [PATCH v2 08/10] net/virtio: remove SSE check Olivier Matz
2017-09-07 12:13 ` [PATCH v2 09/10] net/virtio: keep Rx handler whatever the Tx queue config Olivier Matz
2017-09-07 12:13 ` [PATCH v2 10/10] net/virtio: fix Rx handler when checksum is requested Olivier Matz
2017-09-12 2:31 ` [PATCH v2 00/10] virtio fixes Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831134015.1383-10-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.