From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:40784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbdIAIJE (ORCPT ); Fri, 1 Sep 2017 04:09:04 -0400 Date: Fri, 1 Sep 2017 01:09:04 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: xfs , linux-api@vger.kernel.org, linux-fsdevel , linux-ext4 Subject: Re: [PATCH] fsmap: fix documentation of FMR_OF_LAST Message-ID: <20170901080904.GA32746@infradead.org> References: <20170831204918.GA7404@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831204918.GA7404@magnolia> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Aug 31, 2017 at 01:49:18PM -0700, Darrick J. Wong wrote: > The FMR_OF_LAST flag is set on the last fsmap record being returned for > the dataset requested, contrary to what the header file says. Fix the > docs to reflect the behavior of all fsmap implementations. Hmm. What's the point of the flag then given that you can trivially deduce the last entry from fmh_entries? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] fsmap: fix documentation of FMR_OF_LAST Date: Fri, 1 Sep 2017 01:09:04 -0700 Message-ID: <20170901080904.GA32746@infradead.org> References: <20170831204918.GA7404@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel , linux-ext4 To: "Darrick J. Wong" Return-path: Content-Disposition: inline In-Reply-To: <20170831204918.GA7404@magnolia> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-ext4.vger.kernel.org On Thu, Aug 31, 2017 at 01:49:18PM -0700, Darrick J. Wong wrote: > The FMR_OF_LAST flag is set on the last fsmap record being returned for > the dataset requested, contrary to what the header file says. Fix the > docs to reflect the behavior of all fsmap implementations. Hmm. What's the point of the flag then given that you can trivially deduce the last entry from fmh_entries?