From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdIAKIS (ORCPT ); Fri, 1 Sep 2017 06:08:18 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38287 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730AbdIAKIR (ORCPT ); Fri, 1 Sep 2017 06:08:17 -0400 From: Colin King To: Greg Kroah-Hartman , Tim Sell , David Binder , Sameer Wadgaonkar , Charles Daniels , Andy Shevchenko , sparmaintainer@unisys.com, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][staging-next] staging: unisys: visorbus: make two functions static Date: Fri, 1 Sep 2017 11:08:10 +0100 Message-Id: <20170901100810.17172-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The functions sig_queue_offset and sig_data_offset are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'sig_queue_offset' was not declared. Should it be static? symbol 'sig_data_offset' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/staging/unisys/visorbus/visorchannel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c index 49d1f5f9ef1d..2a000fee3119 100644 --- a/drivers/staging/unisys/visorbus/visorchannel.c +++ b/drivers/staging/unisys/visorbus/visorchannel.c @@ -155,7 +155,7 @@ void *visorchannel_get_header(struct visorchannel *channel) * Return offset of a specific SIGNAL_QUEUE_HEADER from the beginning of a * channel header */ -int sig_queue_offset(struct channel_header *chan_hdr, int q) +static int sig_queue_offset(struct channel_header *chan_hdr, int q) { return ((chan_hdr)->ch_space_offset + ((q) * sizeof(struct signal_queue_header))); @@ -165,8 +165,8 @@ int sig_queue_offset(struct channel_header *chan_hdr, int q) * Return offset of a specific queue entry (data) from the beginning of a * channel header */ -int sig_data_offset(struct channel_header *chan_hdr, int q, - struct signal_queue_header *sig_hdr, int slot) +static int sig_data_offset(struct channel_header *chan_hdr, int q, + struct signal_queue_header *sig_hdr, int slot) { return (sig_queue_offset(chan_hdr, q) + sig_hdr->sig_base_offset + (slot * sig_hdr->signal_size)); -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Date: Fri, 01 Sep 2017 10:08:10 +0000 Subject: [PATCH][staging-next] staging: unisys: visorbus: make two functions static Message-Id: <20170901100810.17172-1-colin.king@canonical.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman , Tim Sell , David Binder , Sameer Wadgaonkar , Charles Daniels , Andy Shevchenko , sparmaintainer@unisys.com, devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King The functions sig_queue_offset and sig_data_offset are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'sig_queue_offset' was not declared. Should it be static? symbol 'sig_data_offset' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/staging/unisys/visorbus/visorchannel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c index 49d1f5f9ef1d..2a000fee3119 100644 --- a/drivers/staging/unisys/visorbus/visorchannel.c +++ b/drivers/staging/unisys/visorbus/visorchannel.c @@ -155,7 +155,7 @@ void *visorchannel_get_header(struct visorchannel *channel) * Return offset of a specific SIGNAL_QUEUE_HEADER from the beginning of a * channel header */ -int sig_queue_offset(struct channel_header *chan_hdr, int q) +static int sig_queue_offset(struct channel_header *chan_hdr, int q) { return ((chan_hdr)->ch_space_offset + ((q) * sizeof(struct signal_queue_header))); @@ -165,8 +165,8 @@ int sig_queue_offset(struct channel_header *chan_hdr, int q) * Return offset of a specific queue entry (data) from the beginning of a * channel header */ -int sig_data_offset(struct channel_header *chan_hdr, int q, - struct signal_queue_header *sig_hdr, int slot) +static int sig_data_offset(struct channel_header *chan_hdr, int q, + struct signal_queue_header *sig_hdr, int slot) { return (sig_queue_offset(chan_hdr, q) + sig_hdr->sig_base_offset + (slot * sig_hdr->signal_size)); -- 2.14.1