From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751942AbdIAKka (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Sep 2017 06:40:30 -0400
Received: from verein.lst.de ([213.95.11.211]:60070 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751725AbdIAKk3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Sep 2017 06:40:29 -0400
Date: Fri, 1 Sep 2017 12:40:27 +0200
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, arve@android.com,
        riandrews@android.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/16] fs: fix kernel_write prototype
Message-ID: <20170901104027.GD25178@lst.de>
References: <20170830150007.3953-1-hch@lst.de> <20170830150007.3953-7-hch@lst.de> <20170830153859.GO5426@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170830153859.GO5426@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 30, 2017 at 04:39:00PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote:
> 
> >  	for (prot = 0; prot < prot_length;) {
> >  		sector_t len = min_t(sector_t, bufsize, prot_length - prot);
> > -		ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot);
> > +		ssize_t ret = kernel_write(prot_fd, buf, len, &pos);
> >  
> >  		if (ret != len) {
> >  			pr_err("vfs_write to prot file failed: %zd\n", ret);
> >  			return ret < 0 ? ret : -ENODEV;
> >  		}
> > -		prot += ret;
> >  	}
> 
> And that loop will terminate because of...?  IOW, the same bug class as in
> the kernel_read() patch.

Also fixed.