From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnqYW-00072w-F6 for qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnqYS-0003hb-5L for qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:36 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:6192) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnqYR-0003fV-SE for qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:32 -0400 Date: Fri, 1 Sep 2017 19:20:22 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= Message-ID: <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> References: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <59A9A6260200007800176A6A@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: qemu-devel@nongnu.org, xen-devel , Stefano Stabellini On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should have been part of the public interface > from the very start. Use them if they're available, falling back to > privately defined values only when using older headers. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > > --- a/hw/xen/xen_pt_msi.c > +++ b/hw/xen/xen_pt_msi.c > @@ -18,6 +18,11 @@ > > #define XEN_PT_AUTO_ASSIGN -1 > > +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK > +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added defines), I guess it doesn't matter much because we only care for stable releases. I would probably be fine without the interface check and the error, but I don't know the approach we usually take regarding those. Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [PATCH] xen: use vMSI related #define-s from public interface Date: Fri, 1 Sep 2017 19:20:22 +0100 Message-ID: <20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local> References: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> <59A9A6260200007800176A6A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnqYR-0002MN-Bd for xen-devel@lists.xenproject.org; Fri, 01 Sep 2017 18:20:31 +0000 Content-Disposition: inline In-Reply-To: <59A9A6260200007800176A6A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: xen-devel , Stefano Stabellini , qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBTZXAgMDEsIDIwMTcgYXQgMTA6MjU6NDJBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gWGVuIGFuZCBxZW11IGhhdmluZyBpZGVudGljYWwgI2RlZmluZS1zICh3aXRoIGRpZmZl cmVudCBuYW1lcykgaXMgYQo+IHN0cm9uZyBoaW50IHRoYXQgdGhlc2Ugc2hvdWxkIGhhdmUgYmVl biBwYXJ0IG9mIHRoZSBwdWJsaWMgaW50ZXJmYWNlCj4gZnJvbSB0aGUgdmVyeSBzdGFydC4gVXNl IHRoZW0gaWYgdGhleSdyZSBhdmFpbGFibGUsIGZhbGxpbmcgYmFjayB0bwo+IHByaXZhdGVseSBk ZWZpbmVkIHZhbHVlcyBvbmx5IHdoZW4gdXNpbmcgb2xkZXIgaGVhZGVycy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpSZXZpZXdlZC1ieTogUm9n ZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Cgo+IAo+IC0tLSBhL2h3L3hlbi94 ZW5fcHRfbXNpLmMKPiArKysgYi9ody94ZW4veGVuX3B0X21zaS5jCj4gQEAgLTE4LDYgKzE4LDEx IEBACj4gIAo+ICAjZGVmaW5lIFhFTl9QVF9BVVRPX0FTU0lHTiAtMQo+ICAKPiArI2lmbmRlZiBY RU5fRE9NQ1RMX1ZNU0lfWDg2X0RFU1RfSURfTUFTSwo+ICsjaWYgWEVOX0RPTUNUTF9JTlRFUkZB Q0VfVkVSU0lPTiA+PSAweDAwMDAwMDBlCgpYRU5fRE9NQ1RMX0lOVEVSRkFDRV9WRVJTSU9OIGlz IGFscmVhZHkgMHhlICh3aXRob3V0IHlvdSBhZGRlZApkZWZpbmVzKSwgSSBndWVzcyBpdCBkb2Vz bid0IG1hdHRlciBtdWNoIGJlY2F1c2Ugd2Ugb25seSBjYXJlIGZvcgpzdGFibGUgcmVsZWFzZXMu CgpJIHdvdWxkIHByb2JhYmx5IGJlIGZpbmUgd2l0aG91dCB0aGUgaW50ZXJmYWNlIGNoZWNrIGFu ZCB0aGUgZXJyb3IsCmJ1dCBJIGRvbid0IGtub3cgdGhlIGFwcHJvYWNoIHdlIHVzdWFsbHkgdGFr ZSByZWdhcmRpbmcgdGhvc2UuCgpUaGFua3MsIFJvZ2VyLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==