From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Sat, 2 Sep 2017 00:06:08 +0100 Subject: [PATCH] ARM: mm: Remove dead code in mem_init() In-Reply-To: References: <1502700269-24384-1-git-send-email-vladimir.murzin@arm.com> <1502700269-24384-3-git-send-email-vladimir.murzin@arm.com> Message-ID: <20170901230608.GX20805@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 01, 2017 at 11:35:16AM +0100, Vladimir Murzin wrote: > On 14/08/17 09:44, Vladimir Murzin wrote: > > The code in question checks memory constrains to set default policy for > > overcommit; however we support page size of 4K only thus condition is > > always evaluated to false. Remove that dead code. > > > > Signed-off-by: Vladimir Murzin > > --- > > arch/arm/mm/init.c | 10 ---------- > > 1 file changed, 10 deletions(-) > > > > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > > index ad80548..81d4482 100644 > > --- a/arch/arm/mm/init.c > > +++ b/arch/arm/mm/init.c > > @@ -580,16 +580,6 @@ void __init mem_init(void) > > BUILD_BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE > PAGE_OFFSET); > > BUG_ON(PKMAP_BASE + LAST_PKMAP * PAGE_SIZE > PAGE_OFFSET); > > #endif > > - > > - if (PAGE_SIZE >= 16384 && get_num_physpages() <= 128) { > > - extern int sysctl_overcommit_memory; > > - /* > > - * On a machine this small we won't get > > - * anywhere without overcommit, so turn > > - * it on by default. > > - */ > > - sysctl_overcommit_memory = OVERCOMMIT_ALWAYS; > > - } > > } > > > > #ifdef CONFIG_STRICT_KERNEL_RWX > > > > Ok for patch tracker? Yep. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up