From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Guy Briggs Subject: Re: [RFC PATCH 3/5] audit: don't use simple_strtol() anymore Date: Sun, 3 Sep 2017 00:50:19 -0400 Message-ID: <20170903045019.GD29957@madcap2.tricolour.ca> References: <150427308165.12725.586957152605521398.stgit@sifl> <150427349179.12725.6280172287635037942.stgit@sifl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <150427349179.12725.6280172287635037942.stgit@sifl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Paul Moore Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On 2017-09-01 09:44, Paul Moore wrote: > From: Paul Moore > > The simple_strtol() function is deprecated, use kstrtol() instead. > > Signed-off-by: Paul Moore Reviewed-by: Richard Guy Briggs > --- > kernel/audit.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index de8a9b8465ae..9df2ef4d3e53 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1566,8 +1566,13 @@ postcore_initcall(audit_init); > /* Process kernel command-line parameter at boot time. audit=0 or audit=1. */ > static int __init audit_enable(char *str) > { > - audit_default = !!simple_strtol(str, NULL, 0); > - if (!audit_default) > + long val; > + > + if (kstrtol(str, 0, &val)) > + panic("audit: invalid 'audit' parameter value (%s)\n", str); > + audit_default = (val ? AUDIT_ON : AUDIT_OFF); > + > + if (audit_default == AUDIT_OFF) > audit_initialized = AUDIT_DISABLED; > audit_enabled = audit_default; > audit_ever_enabled = !!audit_enabled; > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635