From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v4 1/2] eal: add uevent monitor for hot plug
Date: Sun, 3 Sep 2017 09:12:00 -0700
Message-ID: <20170903091200.206bb549@xeon-e3>
References: <1498712510-44217-2-git-send-email-jia.guo@intel.com>
 <1504453785-15735-1-git-send-email-jia.guo@intel.com>
 <1504453785-15735-2-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: bruce.richardson@intel.com, dev@dpdk.org, gaetan.rivet@6wind.com,
 shreyansh.jain@nxp.com, jblunck@infradead.org, helin.zhang@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com, thomas@monjalon.net,
 jingjing.wu@intel.com
To: Jeff Guo <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53])
 by dpdk.org (Postfix) with ESMTP id D9F3258F6
 for <dev@dpdk.org>; Sun,  3 Sep 2017 18:12:02 +0200 (CEST)
Received: by mail-pg0-f53.google.com with SMTP id 83so12620670pgb.4
 for <dev@dpdk.org>; Sun, 03 Sep 2017 09:12:02 -0700 (PDT)
In-Reply-To: <1504453785-15735-2-git-send-email-jia.guo@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun,  3 Sep 2017 23:49:44 +0800
Jeff Guo <jia.guo@intel.com> wrote:

> +int
> +rte_eal_uev_enable(int netlink_fd)
> +{
> +	struct sockaddr_nl addr;
> +	int ret;
> +	int size = 64 * 1024;
> +	int nonblock = 1;
> +	memset(&addr, 0, sizeof(addr));

Blank line between declarations and code.
Also use C99 style intializations not memset.

> +	addr.nl_family = AF_NETLINK;
> +	addr.nl_pid = 0;
> +	addr.nl_groups = 0xffffffff;

You don't need or want all events. specify which group you want.

> +
> +	setsockopt(netlink_fd, SOL_SOCKET, SO_RCVBUFFORCE, &size, sizeof(size));

Don't user BUFFORCE, that is only available as root. Just doing SO_RCVBUF is enough.