From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet
	Rx queues
Date: Mon, 4 Sep 2017 12:07:50 +0530
Message-ID: <20170904063749.GA18430@jerin>
References: <20170707155707.GA6245@jerin>
 <3d2d78cc-9572-bf95-6d25-9b350da62827@intel.com>
 <20170710104126.GA13609@jerin>
 <4197b5f1-9a15-5892-12d2-6bd142bc4d85@intel.com>
 <20170713184445.GA3659@jerin>
 <123ed8d6-4fd9-8bee-d86e-d270a092169e@intel.com>
 <20170729151252.GA25166@jerin>
 <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com>
 <20170801164242.GA6467@jerin>
 <bf41f570-cd12-5e02-66a8-4c1db730bd4d@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net,
 bruce.richardson@intel.com, harry.van.haaren@intel.com,
 hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com,
 Abhinandan Gujjar <abhinandan.gujjar@intel.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0081.outbound.protection.outlook.com [104.47.32.81])
 by dpdk.org (Postfix) with ESMTP id AD8D158F6
 for <dev@dpdk.org>; Mon,  4 Sep 2017 08:38:11 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <bf41f570-cd12-5e02-66a8-4c1db730bd4d@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 11 Aug 2017 10:55:38 +0530
> From: "Rao, Nikhil" <nikhil.rao@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net,
>  bruce.richardson@intel.com, harry.van.haaren@intel.com,
>  hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com,
>  Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> Subject: Re: [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues
> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>  Thunderbird/52.2.1
> 
> On 8/1/2017 10:12 PM, Jerin Jacob wrote:
> > > I have had the application specify the name. so that it can call
> > > 
> > > struct rte_service_spec *rte_service_get_by_name(const char *name);
> > 
> > OK. I was thinking like there will be fixed name for the rx_adapter
> > service like "eth_rx_adapter_%d"(%d for adapter id) which be exposed in
> > rte_event_eth_rx_adapter.h.
> > It can help in removing cfg.service_name. I am fine with either way.
> > 
> 
> OK, I will use a fixed name.
> 
> > > > eventdev PMD op api(not as adapter PMD as discussed earlier)
> > > > -------------------
> > > > 
> > > > 1) typedef uint64_t (*eventdev_rx_adap_capa)(struct rte_eventdev *dev,  uint8_t ethdev_id)
> > > > 
> > > > Return the adapter capability of a given eventdev when it needs to
> > > > connected to a specific ethdev_id
> > > > 
> > > 
> > > Doesn't the capability of a <eventdev, ethdev> also need to be made
> > > available to the application as an adapter API ?
> > 
> > Yes. Make sense to expose as adapter API also.
> > 
> 
> Correcting myself, Isn't this really an eventdev API ? An adapter API would
> take an adapter id argument which is unnecessary in this case.
> 
> Nikhil

Nikhil,

Are you planning to send the updated version? I would like this get
merged in v17.11 to remove eventdev's EXPERIMENTAL status.