From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753424AbdIDKVU (ORCPT ); Mon, 4 Sep 2017 06:21:20 -0400 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:40490 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751321AbdIDKVT (ORCPT ); Mon, 4 Sep 2017 06:21:19 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Date: Mon, 4 Sep 2017 11:18:49 +0100 From: Charles Keepax To: Robert Jarzmik CC: Dmitry Torokhov , Lee Jones , Jaroslav Kysela , Takashi Iwai , Daniel Mack , Haojian Zhuang , Liam Girdwood , Mark Brown , Lars-Peter Clausen , Charles Keepax , , , , , Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> References: <20170902195414.3699-1-robert.jarzmik@free.fr> <20170902195414.3699-10-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=8 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1709040166 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote: > Add support for the new ac97 bus model, where devices are automatically > discovered on AC-Links. > > Signed-off-by: Robert Jarzmik > --- > Since v4: > - added #ifdef spotted by Charles > --- > snd_soc_codec_init_regmap(codec, regmap); > @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec) > struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec); > > snd_soc_codec_exit_regmap(codec); > - snd_soc_free_ac97_codec(wm9712->ac97); > + if (!wm9712->mfd_pdata) > + snd_soc_free_ac97_codec(wm9712->ac97); This bit is still missing the ifdef it has in the preceeding patch. Otherwise looks good to me. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support Date: Mon, 4 Sep 2017 11:18:49 +0100 Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> References: <20170902195414.3699-1-robert.jarzmik@free.fr> <20170902195414.3699-10-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Robert Jarzmik Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , linux-kernel@vger.kernel.org, Dmitry Torokhov , Takashi Iwai , Haojian Zhuang , patches@opensource.wolfsonmicro.com, Mark Brown , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Charles Keepax , Lee Jones , Daniel Mack List-Id: linux-input@vger.kernel.org On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote: > Add support for the new ac97 bus model, where devices are automatically > discovered on AC-Links. > > Signed-off-by: Robert Jarzmik > --- > Since v4: > - added #ifdef spotted by Charles > --- > snd_soc_codec_init_regmap(codec, regmap); > @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec) > struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec); > > snd_soc_codec_exit_regmap(codec); > - snd_soc_free_ac97_codec(wm9712->ac97); > + if (!wm9712->mfd_pdata) > + snd_soc_free_ac97_codec(wm9712->ac97); This bit is still missing the ifdef it has in the preceeding patch. Otherwise looks good to me. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: ckeepax@opensource.cirrus.com (Charles Keepax) Date: Mon, 4 Sep 2017 11:18:49 +0100 Subject: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr> References: <20170902195414.3699-1-robert.jarzmik@free.fr> <20170902195414.3699-10-robert.jarzmik@free.fr> Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote: > Add support for the new ac97 bus model, where devices are automatically > discovered on AC-Links. > > Signed-off-by: Robert Jarzmik > --- > Since v4: > - added #ifdef spotted by Charles > --- > snd_soc_codec_init_regmap(codec, regmap); > @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec) > struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec); > > snd_soc_codec_exit_regmap(codec); > - snd_soc_free_ac97_codec(wm9712->ac97); > + if (!wm9712->mfd_pdata) > + snd_soc_free_ac97_codec(wm9712->ac97); This bit is still missing the ifdef it has in the preceeding patch. Otherwise looks good to me. Thanks, Charles