From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbdIDMS4 (ORCPT ); Mon, 4 Sep 2017 08:18:56 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39470 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbdIDMSy (ORCPT ); Mon, 4 Sep 2017 08:18:54 -0400 Date: Mon, 4 Sep 2017 13:18:39 +0100 From: Mark Brown To: Arnaud Pouliquen Cc: Lin Huang , "dgreif@chromium.org" , "alsa-devel@alsa-project.org" , "lgirdwood@gmail.com" , "briannorris@chromium.org" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "mka@chromium.org" , "dianders@chromium.org" Subject: Re: [PATCH v2 1/2] ASoC: codec: use enable pin to control dmic start and stop Message-ID: <20170904121839.2hkk4anngjjo2ywl@sirena.org.uk> References: <1502936685-24414-1-git-send-email-hl@rock-chips.com> <63c1d120-9c50-93ef-9ea0-be882ac8de1c@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ujhwzci2zuiayqp3" Content-Disposition: inline In-Reply-To: <63c1d120-9c50-93ef-9ea0-be882ac8de1c@st.com> X-Cookie: Often things ARE as bad as they seem! User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ujhwzci2zuiayqp3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 04, 2017 at 12:03:21PM +0200, Arnaud Pouliquen wrote: > > +static const struct snd_soc_dai_ops dmic_dai_ops = { > > + .trigger = dmic_daiops_trigger, > > +}; > should it be handle by trigger or DAPM? DAPM is a bit better, yes. I don't think it matters *overly* much in this case where there's nothing else going on with the device, though bypass use cases would need it. OTOH it could mess up the timing. I was on the edge with this one but I decided that if it ends up making a problem the binding is fine and the code can be sorted later. --ujhwzci2zuiayqp3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmtRJwACgkQJNaLcl1U h9Ajkgf+M1xyDOyPCwKBu5lUwUswKUcw7n3If88zUrT7Q0LQxNWu2Ex9As1Ztekc +tN/XY+kJsX/Sjen6QkycDWzY586vvicM/yOsWCFZBwqART719Z3fjTmTONTERBx dTkVjpDx9u2sgdOwS+C7sfMvV2r2UFRurnblsgxC7rbis3EL0W3EjhEqmz/GRCEI 1kguQofZXA8AYl/vYzORnCk4hgn2294GZU+eDn6pFqB/rZDN8Vg+6XrhGnrQjyHI p5/XFHzOAf9cZRgVnIktmd06acZWm5Q6AL9C0oWkUYqu+3dGIvgLqFlWYjDbXJhu +E+x4TXo7pr0AwGeTzb1Ia5YDz1AqQ== =nfeG -----END PGP SIGNATURE----- --ujhwzci2zuiayqp3--