From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: [PATCH v8 19/21] smiapp: Add support for flash and lens devices Date: Tue, 5 Sep 2017 16:05:51 +0300 Message-ID: <20170905130553.1332-20-sakari.ailus@linux.intel.com> References: <20170905130553.1332-1-sakari.ailus@linux.intel.com> Return-path: In-Reply-To: <20170905130553.1332-1-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org, laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. This does not yet address providing the user space with information on how to associate the sensor or lens devices but the kernel now has the necessary information to do that. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 18 ++++++++++++++++-- drivers/media/i2c/smiapp/smiapp.h | 4 +++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index 700f433261d0..2a7cf430270c 100644 --- a/drivers/media/i2c/smiapp/smiapp-core.c +++ b/drivers/media/i2c/smiapp/smiapp-core.c @@ -31,7 +31,7 @@ #include #include #include -#include +#include #include #include @@ -2887,6 +2887,11 @@ static int smiapp_probe(struct i2c_client *client, v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops); sensor->src->sd.internal_ops = &smiapp_internal_src_ops; + rval = v4l2_fwnode_reference_parse_sensor_common( + &client->dev, &sensor->notifier); + if (rval < 0 && rval != -ENOENT) + return rval; + sensor->vana = devm_regulator_get(&client->dev, "vana"); if (IS_ERR(sensor->vana)) { dev_err(&client->dev, "could not get regulator for vana\n"); @@ -3092,9 +3097,14 @@ static int smiapp_probe(struct i2c_client *client, if (rval < 0) goto out_media_entity_cleanup; + rval = v4l2_async_subdev_notifier_register(&sensor->src->sd, + &sensor->notifier); + if (rval) + goto out_media_entity_cleanup; + rval = v4l2_async_register_subdev(&sensor->src->sd); if (rval < 0) - goto out_media_entity_cleanup; + goto out_unregister_async_notifier; pm_runtime_set_active(&client->dev); pm_runtime_get_noresume(&client->dev); @@ -3105,6 +3115,9 @@ static int smiapp_probe(struct i2c_client *client, return 0; +out_unregister_async_notifier: + v4l2_async_notifier_unregister(&sensor->notifier); + out_media_entity_cleanup: media_entity_cleanup(&sensor->src->sd.entity); @@ -3124,6 +3137,7 @@ static int smiapp_remove(struct i2c_client *client) unsigned int i; v4l2_async_unregister_subdev(subdev); + v4l2_async_notifier_unregister(&sensor->notifier); pm_runtime_disable(&client->dev); if (!pm_runtime_status_suspended(&client->dev)) diff --git a/drivers/media/i2c/smiapp/smiapp.h b/drivers/media/i2c/smiapp/smiapp.h index f74d695018b9..be92cb5713f4 100644 --- a/drivers/media/i2c/smiapp/smiapp.h +++ b/drivers/media/i2c/smiapp/smiapp.h @@ -20,9 +20,10 @@ #define __SMIAPP_PRIV_H_ #include +#include +#include #include #include -#include #include "smiapp-pll.h" #include "smiapp-reg.h" @@ -172,6 +173,7 @@ struct smiapp_subdev { * struct smiapp_sensor - Main device structure */ struct smiapp_sensor { + struct v4l2_async_notifier notifier; /* * "mutex" is used to serialise access to all fields here * except v4l2_ctrls at the end of the struct. "mutex" is also -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:40758 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751641AbdIENGD (ORCPT ); Tue, 5 Sep 2017 09:06:03 -0400 From: Sakari Ailus To: linux-media@vger.kernel.org Cc: niklas.soderlund@ragnatech.se, robh@kernel.org, hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org Subject: [PATCH v8 19/21] smiapp: Add support for flash and lens devices Date: Tue, 5 Sep 2017 16:05:51 +0300 Message-Id: <20170905130553.1332-20-sakari.ailus@linux.intel.com> In-Reply-To: <20170905130553.1332-1-sakari.ailus@linux.intel.com> References: <20170905130553.1332-1-sakari.ailus@linux.intel.com> Sender: linux-media-owner@vger.kernel.org List-ID: Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. This does not yet address providing the user space with information on how to associate the sensor or lens devices but the kernel now has the necessary information to do that. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 18 ++++++++++++++++-- drivers/media/i2c/smiapp/smiapp.h | 4 +++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index 700f433261d0..2a7cf430270c 100644 --- a/drivers/media/i2c/smiapp/smiapp-core.c +++ b/drivers/media/i2c/smiapp/smiapp-core.c @@ -31,7 +31,7 @@ #include #include #include -#include +#include #include #include @@ -2887,6 +2887,11 @@ static int smiapp_probe(struct i2c_client *client, v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops); sensor->src->sd.internal_ops = &smiapp_internal_src_ops; + rval = v4l2_fwnode_reference_parse_sensor_common( + &client->dev, &sensor->notifier); + if (rval < 0 && rval != -ENOENT) + return rval; + sensor->vana = devm_regulator_get(&client->dev, "vana"); if (IS_ERR(sensor->vana)) { dev_err(&client->dev, "could not get regulator for vana\n"); @@ -3092,9 +3097,14 @@ static int smiapp_probe(struct i2c_client *client, if (rval < 0) goto out_media_entity_cleanup; + rval = v4l2_async_subdev_notifier_register(&sensor->src->sd, + &sensor->notifier); + if (rval) + goto out_media_entity_cleanup; + rval = v4l2_async_register_subdev(&sensor->src->sd); if (rval < 0) - goto out_media_entity_cleanup; + goto out_unregister_async_notifier; pm_runtime_set_active(&client->dev); pm_runtime_get_noresume(&client->dev); @@ -3105,6 +3115,9 @@ static int smiapp_probe(struct i2c_client *client, return 0; +out_unregister_async_notifier: + v4l2_async_notifier_unregister(&sensor->notifier); + out_media_entity_cleanup: media_entity_cleanup(&sensor->src->sd.entity); @@ -3124,6 +3137,7 @@ static int smiapp_remove(struct i2c_client *client) unsigned int i; v4l2_async_unregister_subdev(subdev); + v4l2_async_notifier_unregister(&sensor->notifier); pm_runtime_disable(&client->dev); if (!pm_runtime_status_suspended(&client->dev)) diff --git a/drivers/media/i2c/smiapp/smiapp.h b/drivers/media/i2c/smiapp/smiapp.h index f74d695018b9..be92cb5713f4 100644 --- a/drivers/media/i2c/smiapp/smiapp.h +++ b/drivers/media/i2c/smiapp/smiapp.h @@ -20,9 +20,10 @@ #define __SMIAPP_PRIV_H_ #include +#include +#include #include #include -#include #include "smiapp-pll.h" #include "smiapp-reg.h" @@ -172,6 +173,7 @@ struct smiapp_subdev { * struct smiapp_sensor - Main device structure */ struct smiapp_sensor { + struct v4l2_async_notifier notifier; /* * "mutex" is used to serialise access to all fields here * except v4l2_ctrls at the end of the struct. "mutex" is also -- 2.11.0