From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdIEPQh (ORCPT ); Tue, 5 Sep 2017 11:16:37 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:51728 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbdIEPQd (ORCPT ); Tue, 5 Sep 2017 11:16:33 -0400 Date: Tue, 5 Sep 2017 16:15:50 +0100 From: Mark Brown To: =?utf-8?Q?=C5=81ukasz?= Majewski Cc: Nicolin Chen , Timur Tabi , Xiubo Li , Fabio Estevam , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Message-ID: <20170905151550.5mhb535p22lsohlh@sirena.org.uk> References: <1504436701-20700-1-git-send-email-lukma@denx.de> <20170905050602.GA2774@Asurada-CZ80> <20170905075247.GA6112@Asurada> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3iuz7zolhzcycwef" Content-Disposition: inline In-Reply-To: X-Cookie: I'm hungry, time to eat lunch. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3iuz7zolhzcycwef Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 05, 2017 at 10:19:05AM +0200, =C5=81ukasz Majewski wrote: > On 09/05/2017 09:52 AM, Nicolin Chen wrote: > > Can you elaborate why you set ipg clock as bclk? I don't remember SSI c= ould > > derive bitclock from ipg clock. > Just to be clear: > What clock shall be set with: > struct snd_soc_dai_ops { > int (*set_sysclk)(struct snd_soc_dai *dai, > int clk_id, unsigned int freq, int dir); > } > callback? > The SSI IP block or BCLK ? Not the BCLK, probably the IP clock but perhaps nothing. The bclk is usually derived from the sample rate and width, the system clock is the clock rate going into the device. It doesn't *have* to be configured (particuarly if it's discoverable by the IP and managable via the clock API). --3iuz7zolhzcycwef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmuv6UACgkQJNaLcl1U h9AtnAf9EKIG4u66WmYu2NBsfi05jokTgDc1bNTu0zLnl/+F8ryoGAMkfvzlrJGX Mpu73cneyDQuN7H6EVrt57xrlERwnObjioUeBED5gS1z+ViM2j1AEShfIkC3msC5 ug0jgq8gO+IpnJssqag5FfVtToVFvvJNzKP48Y5O9cq2kN0Up81bXom6iLYPKaIF WNJKezxlmZ1GbvvJ3u+fbi6IR9ECIwgkcxndrU4Z6wIJZSsaynA6JerTsqpcwj+b ycCppn4IpOqVtd6XmOpj5wxUb+lPbzzJlWl0PpDOCb8Vnk0zbEq2rHBJy1pNQZ1c ZQts3u2G4Xm+ZXqZn2G1yNyTVwF8fw== =Kce/ -----END PGP SIGNATURE----- --3iuz7zolhzcycwef-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Date: Tue, 5 Sep 2017 16:15:50 +0100 Message-ID: <20170905151550.5mhb535p22lsohlh@sirena.org.uk> References: <1504436701-20700-1-git-send-email-lukma@denx.de> <20170905050602.GA2774@Asurada-CZ80> <20170905075247.GA6112@Asurada> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8994037538014909024==" Return-path: Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 42C0B266BCF for ; Tue, 5 Sep 2017 17:16:30 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: =?utf-8?Q?=C5=81ukasz?= Majewski Cc: alsa-devel@alsa-project.org, Timur Tabi , Xiubo Li , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Nicolin Chen , Fabio Estevam , linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org --===============8994037538014909024== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3iuz7zolhzcycwef" Content-Disposition: inline --3iuz7zolhzcycwef Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 05, 2017 at 10:19:05AM +0200, =C5=81ukasz Majewski wrote: > On 09/05/2017 09:52 AM, Nicolin Chen wrote: > > Can you elaborate why you set ipg clock as bclk? I don't remember SSI c= ould > > derive bitclock from ipg clock. > Just to be clear: > What clock shall be set with: > struct snd_soc_dai_ops { > int (*set_sysclk)(struct snd_soc_dai *dai, > int clk_id, unsigned int freq, int dir); > } > callback? > The SSI IP block or BCLK ? Not the BCLK, probably the IP clock but perhaps nothing. The bclk is usually derived from the sample rate and width, the system clock is the clock rate going into the device. It doesn't *have* to be configured (particuarly if it's discoverable by the IP and managable via the clock API). --3iuz7zolhzcycwef Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmuv6UACgkQJNaLcl1U h9AtnAf9EKIG4u66WmYu2NBsfi05jokTgDc1bNTu0zLnl/+F8ryoGAMkfvzlrJGX Mpu73cneyDQuN7H6EVrt57xrlERwnObjioUeBED5gS1z+ViM2j1AEShfIkC3msC5 ug0jgq8gO+IpnJssqag5FfVtToVFvvJNzKP48Y5O9cq2kN0Up81bXom6iLYPKaIF WNJKezxlmZ1GbvvJ3u+fbi6IR9ECIwgkcxndrU4Z6wIJZSsaynA6JerTsqpcwj+b ycCppn4IpOqVtd6XmOpj5wxUb+lPbzzJlWl0PpDOCb8Vnk0zbEq2rHBJy1pNQZ1c ZQts3u2G4Xm+ZXqZn2G1yNyTVwF8fw== =Kce/ -----END PGP SIGNATURE----- --3iuz7zolhzcycwef-- --===============8994037538014909024== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============8994037538014909024==--