From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbdIFNRu (ORCPT ); Wed, 6 Sep 2017 09:17:50 -0400 Received: from mail.skyhub.de ([5.9.137.197]:35464 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdIFNRr (ORCPT ); Wed, 6 Sep 2017 09:17:47 -0400 Date: Wed, 6 Sep 2017 15:17:36 +0200 From: Borislav Petkov To: David Hildenbrand Cc: KVM , LKML , Janakarajan Natarajan , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH] KVM: SVM: Do not issue virtual VMLOAD/VMSAVE supported-message Message-ID: <20170906131736.4tkvjveqjfmkdpxo@pd.tnic> References: <20170905170628.10211-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 02:54:05PM +0200, David Hildenbrand wrote: > Maybe go one step further and incorporate everything (+vls) into a > single if statement? Or maybe simplify it even more by not even looking at vls. If the user disables it, fine, if she enables it but the hw doesn't support it, it will be set to false automatically. Or am I missing a case? --- From: Borislav Petkov Date: Tue, 5 Sep 2017 18:59:55 +0200 Subject: [PATCH] KVM: SVM: Do not issue virtual VMLOAD/VMSAVE supported-message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There's no need to issue that everytime during boot - we have the /proc/cpuinfo flag for people and software to query. Also, simplify logic which verifies the vls chicken bit setting. Signed-off-by: Borislav Petkov Cc: David Hildenbrand Cc: Janakarajan Natarajan Cc: Paolo Bonzini Cc: Radim Krčmář --- arch/x86/kvm/svm.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 8dbd8dbc83eb..d3c481778d9c 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1098,15 +1098,10 @@ static __init int svm_hardware_setup(void) } } - if (vls) { - if (!npt_enabled || - !boot_cpu_has(X86_FEATURE_V_VMSAVE_VMLOAD) || - !IS_ENABLED(CONFIG_X86_64)) { - vls = false; - } else { - pr_info("Virtual VMLOAD VMSAVE supported\n"); - } - } + if (!npt_enabled || + !boot_cpu_has(X86_FEATURE_V_VMSAVE_VMLOAD) || + !IS_ENABLED(CONFIG_X86_64)) + vls = false; return 0; -- 2.13.0 -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.