From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional
Date: Wed, 6 Sep 2017 13:32:45 +0200 [thread overview]
Message-ID: <20170906133245.716cbbc6@windsurf.lan> (raw)
In-Reply-To: <CAAP7uc+GQ51G_8P6+L4VmBmFJf6i4iD0f4V-LM9=QzRBLKFjKA@mail.gmail.com>
Hello,
On Wed, 6 Sep 2017 10:38:25 +0200, Aleksander Morgado wrote:
> > All in all, isn't it simpler to get rid of those options, and simply do:
> >
> > ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
> > ... enable support
>
> When doing this, should I also include a direct dependency on
> libgudev, so that libgudev is built before libqmi always?
> LIBQMI_DEPENDENCIES += libgudev
Well, if you don't do this, libgudev is not guaranteed to be built
before libqmi, so you would get a build failure, right ?
The canonical way to express optional dependencies is:
ifeq ($(BR2_PACKAGE_FOO),y)
BAR_DEPENDENCIES += foo
BAR_CONF_OPTS += --enable-foo
else
BAR_CONF_OPTS += --disable-foo
endif
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-09-06 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 10:03 [Buildroot] [PATCH] libqmi: udev and qmi-over-mbim are optional Aleksander Morgado
2017-09-05 19:36 ` Thomas Petazzoni
2017-09-05 19:45 ` Aleksander Morgado
2017-09-06 6:54 ` Thomas Petazzoni
2017-09-06 8:38 ` Aleksander Morgado
2017-09-06 11:32 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906133245.716cbbc6@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.